Update PUBLIC_DOMAINS to PUBLIC_DOMAINS_SET to improve performance #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
Beamanator
approved these changes
Jun 9, 2025
Contributor
Beamanator
left a comment
Beamanator
left a comment
There was a problem hiding this comment.
Looks great! Though it would be best if you could explain at least a little bit "why" this is helpful / why this improves performance
Beamanator
requested changes
Jun 9, 2025
Contributor
Beamanator
left a comment
Beamanator
left a comment
There was a problem hiding this comment.
Actually we may need to keep the old var around, then update other repos to use the new var, then we can clean up and delete the old one - otherwise this could break existing flows before we update other repos to use the new var
pasyukevich
force-pushed
the
performance/domains-array-to-set
branch
from
ba87bf4 to
4be3a79
Compare
srikarparsi
approved these changes
Jun 9, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
$ Expensify/App#63736
Tests
QA