Skip to content

Update PUBLIC_DOMAINS to PUBLIC_DOMAINS_SET to improve performance #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Update PUBLIC_DOMAINS to PUBLIC_DOMAINS_SET to improve performance #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d1820
Update PUBLIC_DOMAINS to PUBLIC_DOMAINS_SET to improve performance
pasyukevich Jun 5, 2025
4be3a79
Deprecate PUBLIC_DOMAINS in favor of PUBLIC_DOMAINS_SET and update ex…
pasyukevich Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,10 @@ const UI = {
DIALOG_Z_INDEX: 4000,
} as const;

// List of most frequently used public domains
/**
* List of most frequently used public domains
* @deprecated use PUBLIC_DOMAINS_SET instead
*/
const PUBLIC_DOMAINS = [
'accountant.com',
'afis.ch',
Expand Down Expand Up @@ -1064,4 +1067,6 @@ const PUBLIC_DOMAINS = [
'ymail.com',
] as const;

export {g_cloudFront, g_cloudFrontImg, CONST, UI, PUBLIC_DOMAINS};
const PUBLIC_DOMAINS_SET = new Set<string>(PUBLIC_DOMAINS);

export {g_cloudFront, g_cloudFrontImg, CONST, UI, PUBLIC_DOMAINS_SET, PUBLIC_DOMAINS};
2 changes: 1 addition & 1 deletion lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
export {default as API} from './API';
export {default as APIDeferred} from './APIDeferred';
export {default as BrowserDetect} from './BrowserDetect';
export {g_cloudFront, g_cloudFrontImg, CONST, UI, PUBLIC_DOMAINS} from './CONST';
export {g_cloudFront, g_cloudFrontImg, CONST, UI, PUBLIC_DOMAINS_SET, PUBLIC_DOMAINS} from './CONST';

export {default as Cookie} from './Cookie';
export {default as CredentialsWrapper, LOGIN_PARTNER_DETAILS} from './CredentialsWrapper';
Expand Down