Add more constants since web-s has a constant file deleted #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonilBhavsar
reviewed
Aug 4, 2025
MonilBhavsar
reviewed
Aug 4, 2025
| 'oauth.chase.com': 90, | ||
| 'discover.com': 30, | ||
| 'admin.pexcard.com': 30, | ||
| svbdirect: 75, |
There was a problem hiding this comment.
Should this be a string?
Suggested change
| svbdirect: 75, | |
| 'svbdirect': 75, |
There was a problem hiding this comment.
For some reason, I am unable to add quotes around it, can you please check this on your end?
There was a problem hiding this comment.
Hmm, now that I have add the quotes forcefully it is throwing linter error.
Screen.Recording.2025-08-04.at.2.28.24.PM.movSorry went AFK, I rebuild both web-e/web-s and reproduced the issue and added the testing step. |
madmax330
previously approved these changes
Aug 4, 2025
|
Need to run prettier still apparently |
|
I don't see anything when I run |
MonilBhavsar
reviewed
Aug 4, 2025
.prettierrc.js
Outdated
| @@ -6,4 +6,5 @@ module.exports = { | |||
| arrowParens: 'always', | |||
| printWidth: 190, | |||
| singleAttributePerLine: true, | |||
| quoteProps: 'consistent', | |||
There was a problem hiding this comment.
Is prettier failing because of this change, and not the quotes around the bank name?
MonilBhavsar
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constants where removed here https://github.com/Expensify/Web-Secure/pull/2885
CC @AndrewGable @madmax330
Coming from discussion here https://expensify.slack.com/archives/C03SSAQ7P/p1754285585977329, we observed that a few constants that were removed as part of deleting
00constant.jsfile exists nowhere in our codebase and resulted in a few regression so through this PR we try to backfill the missing constants.Fixed Issues
N/A
Tests
Settings > Wallet.Import Card/Bankand select any option among first 6.Log Inpage is shown.QA
Same as tests.