Skip to content

Add more constants since web-s has a constant file deleted #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2025
Merged

Add more constants since web-s has a constant file deleted #875

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77080b7
add more cosntants
techievivek Aug 4, 2025
8787623
remove GB
techievivek Aug 4, 2025
f0a0802
get rid of a few const since they are unused
techievivek Aug 4, 2025
ae052d1
add quotes
techievivek Aug 4, 2025
5f11b0f
remove quuote change
techievivek Aug 4, 2025
913bfa4
remove quote
techievivek Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions lib/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ const CONST = {
*/
ACH_DEFAULT_MAX_AMOUNT_LIMIT: 2000000,

/**
* This is set in main.html and is derived from a PHP template variable
* @type {String}
*/
URL_TO_SECURE_WEBSITE: '',

/**
* IRS remimbursement rate for mileage
* WARNING ! UPDATE THE PHP CONSTANT VERSION WHEN UPDATING THIS ONE
Expand All @@ -42,7 +48,9 @@ const CONST = {

COUNTRY: {
US: 'US',
MX: 'MX',
AU: 'AU',
CA: 'CA',
UK: 'UK',
NZ: 'NZ',
},
Expand Down Expand Up @@ -447,6 +455,11 @@ const CONST = {
MAX_AGE_SAME_COMMENT: 300,

SMARTREPORT_AGENT_EMAIL: '[email protected]',

/**
* Email to submit smart reports to (alias for consistency)
*/
SMART_REPORT_AGENT_EMAIL: '[email protected]',
},

/**
Expand Down Expand Up @@ -572,6 +585,23 @@ const CONST = {
VERIFICATION_MAX_ATTEMPTS: 7,
},

// The number of days that certain banks limit their transaction imports to
// see https://stackoverflow.com/c/expensify/questions/1289/1290#1290 for more about this.
// If a bank isn't on this list, we default to 90 days
BANK_IMPORT_DAY_LIMITS: {
'americanexpress.com': 30,
'oauth.bankofamerica.com': 30,
'oauth.capitalone.com': 90,
'oauth.chase.com': 90,
'discover.com': 30,
'admin.pexcard.com': 30,
svbdirect: 75,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a string?

Suggested change
svbdirect: 75,
'svbdirect': 75,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, I am unable to add quotes around it, can you please check this on your end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, now that I have add the quotes forcefully it is throwing linter error.

'oauth.wellsfargo.com': 30,
},
DEFAULT_BANK_IMPORT_DAYS: 90,
PERSONAL_CARD_START_DATE_TOOLTIP:
'Expensify will automatically import the earliest available transactions from this card. If a start date is selected, transactions with a posted date prior to this will not be included.',

/**
* Emails that the user shouldn't be interacting with from the front-end interface
* Trying to add these emails as a delegate, onto a policy, or as an approver is considered invalid
Expand Down