Revert "Fix negativity check in codegen" #59986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
approved these changes
Oct 29, 2025
Member
Author
|
Confirmed that the stacktraces tests are passing now: https://buildkite.com/julialang/julia-master/builds/51772#019a312d-5449-4941-9454-56f4061c813a |
Member
|
I think that's sufficient for us to merge this early. |
Member
Author
|
I'm going to merge this PR to unbreak most of the tests. All nightly builds are currently stuck on b63991c because of this issue. |
yuyichao
added a commit
that referenced
this pull request
Oct 29, 2025
This partially reverts commit f8c7b22.
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #59971, ref #59971 (comment)