Skip to content

Revert "Fix negativity check in codegen" #59986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Revert "Fix negativity check in codegen" #59986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/codegen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4137,7 +4137,7 @@ static bool emit_builtin_call(jl_codectx_t &ctx, jl_cgval_t *ret, jl_value_t *f,
if (argv[2].constant) {
if (!jl_is_long(argv[2].constant))
return false;
auto nel = jl_unbox_long(argv[2].constant);
size_t nel = jl_unbox_long(argv[2].constant);
if (nel < 0)
return false;
*ret = emit_const_len_memorynew(ctx, typ, nel, inst);
Expand Down Expand Up @@ -8935,7 +8935,7 @@ static jl_llvm_functions_t
if (!jl_is_symbol(debuginfo->def)) // this is a path
func = debuginfo->def; // this is inlined
struct jl_codeloc_t lineidx = jl_uncompress1_codeloc(debuginfo->codelocs, pc);
ssize_t i = lineidx.line;
size_t i = lineidx.line;
if (i < 0) // pc out of range: broken debuginfo?
return false;
if (i == 0 && lineidx.to == 0) // no update
Expand Down