Skip to content

Conversation

Jonas-a-Zimmermann
Copy link

Description

Removed the expand_extrema! call in the bar recipe, as this leads to an issue with the permute option;
see #5009

Attribution

@BeastyBlacksmith
Copy link
Member

Couldn't we swap the limits?

@Jonas-a-Zimmermann
Copy link
Author

I suppose you could move the code from e786ff5 into the bar recipe itself, however i do net see the benefit of that.
(well i suppose it could solve the widening isssue #4949 aswell)

However, (I think) the usage of expand_extrema is in the best case redundant (it is and has to be called downstream, to ensure linking axis works), and in the worst case errors like these happen, thus just not using it within recipes seems like the proper way to me.
However, do note that i am not that familiar with the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants