Skip to content

Incorrect Behavior of Bars under (:permute) -> remove the expand_extrema call #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Incorrect Behavior of Bars under (:permute) -> remove the expand_extrema call #5010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9961c
Remove widening in Bar recpie
Jonas-a-Zimmermann Oct 31, 2024
6caac93
Removed now inaccurate comment
Jonas-a-Zimmermann Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .zenodo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,11 @@
{
"name": "Patrick Jaap",
"type": "Other"
},
{
"affiliation": "Ludwig-Maximilians-Universiaet Muenchen",
"name": "Jonas Zimmermann",
"type": "Other"
}
],
"upload_type": "software"
Expand Down
2 changes: 1 addition & 1 deletion src/pipeline.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ function RecipesPipeline.add_series!(plt::Plot, plotattributes)
elseif ms === :vline && (perm == (:x, :y) || perm == (:y, :x))
plotattributes[:markershape] = :hline
end
if plotattributes[:seriestype] === :bar # bar calls expand_extrema! in its recipe...
if plotattributes[:seriestype] === :bar
sp = plotattributes[:subplot]
sp[get_attr_symbol(letter1, :axis)][:lims],
sp[get_attr_symbol(letter2, :axis)][:lims] =
Expand Down
3 changes: 0 additions & 3 deletions src/recipes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,6 @@ end
push!(yseg, yi, fi, fi, yi, yi)
end

# widen limits out a bit
expand_extrema!(axis, scale_lims(ignorenan_extrema(xseg.pts)..., default_widen_factor))

# switch back
if !isvertical(plotattributes)
xseg, yseg = yseg, xseg
Expand Down
Loading