Fix run config not found error in generate sample

[sfierro]

Summary by CodeRabbit

• New Features

  • Generated outputs now include run configuration details for improved traceability.
  • Consistent handling of run configuration across single and bulk generation flows.

• Bug Fixes

  • Added validation to prevent starting generations without required configuration, with clearer error feedback.
  • Reduced failures in batch generation by ensuring configuration is reliably passed to each worker.

[coderabbitai]

Walkthrough

Propagates run_config_properties through the synth generation flow in +page.svelte: updates worker and sample generation functions to accept and pass the properties, includes them in API payloads as output_run_config_properties, and adds guards to ensure presence.

Changes

Cohort / File(s)	Summary of changes
RunConfig propagation in synth page app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte	Import RunConfigProperties and Task; thread run_config_properties through generate_all_samples → generate_worker → generate_sample; include as output_run_config_properties in API request; remove in-function retrieval; add guards/throws when missing; update post-call usage to rely on passed properties.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant UI as Synth Page
  participant Pool as Worker Queue
  participant Worker as generate_worker()
  participant Gen as generate_sample()
  participant API as Backend API

  UI->>UI: get run_config_properties
  UI->>Pool: generate_all_samples(run_config_properties)
  Note over UI,Pool: Guard: throw if run_config_properties missing

  loop For each job
    Pool->>Worker: generate_worker(queue, run_config_properties)
    Note over Worker: Guard: throw if run_config_properties missing
    Worker->>Gen: generate_sample(job, run_config_properties)
    Gen->>API: POST payload{ output_run_config_properties: ... }
    API-->>Gen: response
    Gen-->>Worker: result
    Worker-->>Pool: result
  end

  Pool-->>UI: aggregated results

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor: synth data page become routing entry point to different modes #725 — Adjusts synth generation workflow (worker pool and sample generation paths), overlapping with this PR’s control-flow updates.
• [KIL-145] Refactor SDG generate outputs dialog to use new RunConfigComponent #719 — Replaces discrete output fields with RunConfigProperties and wires it through generate_sample/worker calls, matching this PR’s propagation pattern.

Suggested reviewers

• leonardmq

Poem

A whisk of configs, neatly passed along,
I thump my paw—our pipelines now strong.
From queue to worker, samples align,
Output props tucked in, crisp by design.
Carrot-shaped payloads hop to the API—
Synth sings “OK,” and so do I. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request lacks any description and does not follow the required template sections for describing the goal, related issues, contributor agreement, or checklists.	Please add a description following the repository template including the PR goal, related issue links, contributor license agreement confirmation, and completed test checklists.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly summarizes the primary change by referencing the run config error and its location in generate sample, matching the main objective of the PR.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sfierro/generate_samples_fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📊 Coverage Report

Overall Coverage: 92%

Diff: origin/main...HEAD

No lines with coverage information in this diff.

---

• 📊 HTML Coverage Report - Interactive coverage report
• 📈 Diff Coverage Report - Detailed diff analysis
• Github Actions Run - View the full coverage report

[leonardmq]

Fixes it for me (but there are some merge conflicts)

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte (2)

459-465: Disable Generate submit until run_config_properties is valid
Add a disabled state to the Generate button when run_config_component.run_options_as_run_config_properties() returns falsy to avoid the modal flash with a KilnError.

---

553-553: Confirm backend contract and callers

• Backend POST /generate_sample accepts output_run_config_properties (schema, handler signature and tests updated).
• No other local callers of generate_sample use the old signature.
• Optional: change throw new KilnError("Failed to save sample") to "Failed to generate sample".

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c180318 and 553ba4f.

📒 Files selected for processing (1)

• app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte (5 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

app/web_ui/**/*.{ts,svelte}

📄 CodeRabbit inference engine (.cursor/rules/project.mdc)

app/web_ui/**/*.{ts,svelte}: Write frontend web code in TypeScript; do not add plain .js sources
From the web UI, make backend calls only to our FastAPI servers; do not call external services directly
Use TypeScript types and interfaces to maintain strong typing in the frontend

Files:

• app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte

app/web_ui/**/*.svelte

📄 CodeRabbit inference engine (.cursor/rules/project.mdc)

app/web_ui/**/*.svelte: Author components for Svelte v4 compatibility (do not use Svelte v5-only APIs)
Prefer Tailwind CSS and DaisyUI utility/classes for styling in Svelte components

Files:

• app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte

app/web_ui/**/*.{ts,tsx,svelte}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript for frontend code (including <script lang="ts"> in .svelte files)

Files:

• app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Generate Coverage Report
• GitHub Check: Build Desktop Apps (ubuntu-22.04)
• GitHub Check: Build Desktop Apps (ubuntu-22.04-arm)
• GitHub Check: Build Desktop Apps (macos-13)
• GitHub Check: Build Desktop Apps (windows-latest)
• GitHub Check: Build Desktop Apps (macos-latest)
• GitHub Check: Build, Typecheck, and Test Python (3.10)
• GitHub Check: Build, Typecheck, and Test Python (3.13)

🔇 Additional comments (2)

app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/synth/+page.svelte (2)

5-5: Type import LGTM

Using RunConfigProperties improves type safety and aligns with TS-first frontend guideline.

---

426-429: Plumbing run_config_properties through the worker is correct

Passing run_config_properties fixes the “not found” error and avoids stale lookups. Loop/queue usage remains safe in JS’ single thread. LGTM.

Also applies to: 432-436