Skip to content

Fix run config not found error in generate sample #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Fix run config not found error in generate sample #726

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d52400
potential fix
sfierro Oct 13, 2025
c180318
moved error up higher
sfierro Oct 13, 2025
553ba4f
merged main
sfierro Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions app/web_ui/src/routes/(app)/generate/[project_id]/[task_id]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import AppPage from "../../../app_page.svelte"
import { client } from "$lib/api_client"
import { current_task } from "$lib/stores"
import type { Task } from "$lib/types"
import type { RunConfigProperties, Task } from "$lib/types"
import { KilnError, createKilnError } from "$lib/utils/error_handlers"
import { onMount } from "svelte"
import { page } from "$app/stores"
Expand Down Expand Up @@ -416,10 +416,17 @@
let ui_show_errors = false

// Worker function that processes items until queue is empty
async function generate_worker(queue: SampleData[]) {
async function generate_worker(
queue: SampleData[],
run_config_properties: RunConfigProperties,
) {
while (queue.length > 0) {
const sample = queue.shift()!
const result = await generate_sample(sample, sample.topic_path)
const result = await generate_sample(
sample,
sample.topic_path,
run_config_properties,
)

if (result.error) {
generate_all_sub_errors.push(result.error)
Expand All @@ -442,6 +449,13 @@
let generated_count = 0
async function generate_all_samples() {
try {
// Grab the run config properties before it is no longer available
const run_config_properties =
run_config_component?.run_options_as_run_config_properties()
if (!run_config_properties) {
throw new KilnError("Run config properties not found")
}

generated_count = 0
generate_all_running = true
generate_all_error = null
Expand All @@ -454,7 +468,7 @@
// 5 because browsers can only handle 6 concurrent requests. The 6th is for the rest of the UI to keep working.
const workers = Array(5)
.fill(null)
.map(() => generate_worker(queue))
.map(() => generate_worker(queue, run_config_properties))

// Wait for all workers to complete
await Promise.all(workers)
Expand Down Expand Up @@ -529,13 +543,9 @@
async function generate_sample(
sample: SampleData,
topic_path: string[] | undefined,
run_config_properties: RunConfigProperties,
): Promise<GenerateSampleResponse> {
const run_config_properties =
run_config_component?.run_options_as_run_config_properties()
try {
if (!run_config_properties) {
throw new KilnError("Run config properties not found")
}
const formatted_input = task?.input_json_schema
? JSON.parse(sample.input)
: sample.input
Expand Down
Loading