Hitting Home in the Song-Editor or PianoRoll-Editor resets Time Display #8052
Conversation
src/core/Song.cpp
Outdated
| getPlayPos(playMode).setTicks( ticks ); | ||
| getPlayPos(playMode).setCurrentFrame( 0.0f ); | ||
| getPlayPos(playMode).setJumped( true ); | ||
| setToTime(0); |
There was a problem hiding this comment.
Does this move the play pos to 0 no matter what ticks are passed to the function?
…ction would break). Also fixed incorrect time information when navigating with left/right keys.
|
Compiled because of the lack of workloads. LGTM. |
| getPlayPos(playMode).setCurrentFrame( 0.0f ); | ||
| getPlayPos(playMode).setJumped( true ); | ||
| setToTime(0); | ||
| setToTimeByTicks(ticks); |
There was a problem hiding this comment.
I'm curious why you need to call setToTime/setToTimeByTicks at all, since the play pos is already set a few lines above. Looking at the definitions of those functions, I suppose because setToTime also forcefully sets the millisecond counter (rather than incrementing it as done above on line 610), that may prevent some issues?
There was a problem hiding this comment.
The reason is that TimeDisplayWidget currently uses Song.getMilliseconds() in its updateTime() method.
getMilliseconds() is called without an explicit play mode (so the play mode is taken from the current song, which is set to NONE when stopped). But the position is set beforehand for the SONG play mode.
If I call setPlayPos() with the actual play mode instead of the fixed SONG mode, the indicator bar is not reset when pressing HOME.
So I guess this is the less invasive way to fix that bug.
Song::setPlayPos() is only invoked in the key event handler of SongEditor (left, right, home) and in clearProject(), so I assume it has no side effects.
3 participants
The TimeDisplayWidget retrieves the current song position using getMilliseconds() or playPos().
This time value is not reset to 0 when the Home key is pressed.
#7956