Skip to content

Hitting Home in the Song-Editor or PianoRoll-Editor resets Time Display #8052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Hitting Home in the Song-Editor or PianoRoll-Editor resets Time Display #8052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
314bb65
fix: set timecode of song to 0 when pressing home
aisge Sep 3, 2025
7953c40
unification: always use setToTime()-method
aisge Sep 3, 2025
3ac8a6c
fix: set to the given tick instead of 0 (otherwise the left/right fun…
aisge Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/Song.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ void Song::setPlayPos( tick_t ticks, PlayMode playMode )
getPlayPos(playMode).setTicks( ticks );
getPlayPos(playMode).setCurrentFrame( 0.0f );
getPlayPos(playMode).setJumped( true );
setToTimeByTicks(ticks);
Copy link
Member

@regulus79 regulus79 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why you need to call setToTime/setToTimeByTicks at all, since the play pos is already set a few lines above. Looking at the definitions of those functions, I suppose because setToTime also forcefully sets the millisecond counter (rather than incrementing it as done above on line 610), that may prevent some issues?

Copy link
Author

@aisge aisge Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is that TimeDisplayWidget currently uses Song.getMilliseconds() in its updateTime() method.
getMilliseconds() is called without an explicit play mode (so the play mode is taken from the current song, which is set to NONE when stopped). But the position is set beforehand for the SONG play mode.

If I call setPlayPos() with the actual play mode instead of the fixed SONG mode, the indicator bar is not reset when pressing HOME.
So I guess this is the less invasive way to fix that bug.

Song::setPlayPos() is only invoked in the key event handler of SongEditor (left, right, home) and in clearProject(), so I assume it has no side effects.


// send a signal if playposition changes during playback
if( isPlaying() )
Expand Down
1 change: 1 addition & 0 deletions src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,6 +1459,7 @@ void PianoRoll::keyPressEvent(QKeyEvent* ke)
case Qt::Key_Home:
m_timeLine->pos().setTicks( 0 );
m_timeLine->updatePosition();
Engine::getSong()->setToTimeByTicks(0);
ke->accept();
break;

Expand Down
Loading