chore(proto): remove unused java_package declarations#772
Open
Conversation
pimlock
previously approved these changes
Apr 6, 2026
These .rs files in crates/openshell-core/src/proto/ were never used at build time — mod.rs includes freshly generated code from OUT_DIR via tonic-build. The checked-in copies were massively outdated and misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused
java_packageandjava_multiple_filesoption declarations from proto files. OpenShell has no Java consumers, so these options are dead code.Changes
option java_multiple_files = true;andoption java_package = "..."fromproto/inference.protooption java_multiple_files = true;andoption java_package = "..."fromproto/openshell.protoTesting
mise run pre-commitpassesChecklist