Improve error messaging in HollowIncrementalCyclePopulator #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunjeet
approved these changes
Jun 19, 2025
…being removed from IncrementalProducer does not have a primary key. Previously, a generic NPE would be thrown when trying to construct the HollowPrimaryKeyIndex. Now the offending type will be included in the error to make handling easier.
dansmillie
force-pushed
the
incremental-error-messaging
branch
from
e510206 to
45d65a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error messaging in HollowIncrementalCyclePopulator when Type being removed from IncrementalProducer does not have a primary key.
Previously, a generic NPE would be thrown when trying to construct the HollowPrimaryKeyIndex. Now the offending type will be included in the error.