Skip to content

Improve error messaging in HollowIncrementalCyclePopulator #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

Improve error messaging in HollowIncrementalCyclePopulator #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hollow/src/main/java/com/netflix/hollow/api/producer/HollowIncrementalCyclePopulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ private BitSet markTypeRecordsToRemove(HollowReadStateEngine priorStateEngine, f
HollowSchema schema = priorReadState.getSchema();
int populatedOrdinals = priorReadState.getPopulatedOrdinals().length();
if(schema.getSchemaType() == HollowSchema.SchemaType.OBJECT) {
HollowObjectSchema objectSchema = (HollowObjectSchema) schema;
if (objectSchema.getPrimaryKey() == null) {
throw new IllegalArgumentException("Type " + type + " does not have a primary key defined");
}

final HollowPrimaryKeyIndex idx = new HollowPrimaryKeyIndex(priorStateEngine, ((HollowObjectSchema) schema).getPrimaryKey()); ///TODO: Should we scan instead? Can we create this once and do delta updates?

ThreadSafeBitSet typeRecordsToRemove = new ThreadSafeBitSet(ThreadSafeBitSet.DEFAULT_LOG2_SEGMENT_SIZE_IN_BITS, populatedOrdinals);
Expand Down