Add experimental installer to installer tests #14002
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EXPERIMENTAL_INSTALLER_ARTIFACT="nix-installer-$INSTALLER_ARCH-$INSTALLER_OS" | ||
| EXPERIMENTAL_INSTALLER_PATH="$GITHUB_WORKSPACE/$EXPERIMENTAL_INSTALLER_ARTIFACT" | ||
| # TODO: This uses the latest release. It should probably be pinned, or dogfood the experimental repo's default branch - similar to the above |
There was a problem hiding this comment.
One option would be to add another input and matrix item to allow you to target target both release and master. Though I'd probably add later as needed.
getchoo
force-pushed
the
getchoo/dogfood-experimental-installer
branch
from
43653c6 to
a2fe65b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note
This is part of the discussion with the Nix and Experimental Installer team on 13-08-2025
A good way to test the new installer is to dogfood it alongside the currently existing one. This PR adds that ability to the internal
install-nix-action, and implements it as a scenario to the installer test job matrix :)Context
Runs are currently very inconsistent due to Internal detection of
nixbinary path is inconsistent after Nix 2.29 experimental-nix-installer#47. This will be a draft until that is fixed or a workaround is foundA successful run on Linux (and an example of the above bug occuring on macOS) can be found here
In the future, it would probably be a good idea to use the
mainbranch of the installer alongside themasterversion of Nix. That could be easily added with this workflow though, probably taking example from the already existing methods for finding artifacts. It would only require the experimental installer repo to actually generate artifacts...which it currently doesn't. If the installer was ever pulled in-tree, this would also be even easier!Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.