unittests: convert remaining stream-tcp-reassemble.c tests to FAIL/PA… #14134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SS API This converts all remaining unit tests in stream-tcp-reassemble.c to the new FAIL_IF / PASS API. Old return-based validation (1/-1) in callbacks has been removed, and all tests now use FAIL_IF for immediate assertion failures and PASS at the end of the test functions. Task OISF#6324
3 tasks
|
NOTE: This PR may contain new authors. |
|
This again looks like it wasn't compile tested locally. Please don't submit any more PRs that fail to build or fail to pass unittests or SV. |
|
Replaced by #14138. @kaddujames501-ship-it please next time close the old PR when opening a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6324
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
https://redmine.openinfosecfoundation.org/projects/suricata/issues/
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6324
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
James Kaddu: [email protected]