Allow the simulator to force an output write to be the final one.#5038
Open
blattms wants to merge 1 commit intoOPM:masterfrom
Open
Allow the simulator to force an output write to be the final one.#5038blattms wants to merge 1 commit intoOPM:masterfrom
blattms wants to merge 1 commit intoOPM:masterfrom
Conversation
blattms
added
the
manual:irrelevant
Member
Author
|
jenkins build this opm-simulators=6894 please |
blattms
force-pushed
the
feature/allow-write-rsm-for-actionx-exit
branch
from
dfd6978 to
9b3085d
Compare
The final write is special as it might create an RSM file. Up to now we created this file only for the last write of the last report step of a simulation. This approach neglected that a simulation might finish before the last step if it encounters an EXIT keyword inside of an executed ACTIONX statement. With this change we will also write an RSM file in this case. Such a file was missing before.
blattms
force-pushed
the
feature/allow-write-rsm-for-actionx-exit
branch
from
9b3085d to
ec37934
Compare
Member
Author
|
jenkins build this opm-simulators=6894 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final write is special as it might create an RSM file. Up to now we created this file only for the last write of the last report step of a simulation.
This approach neglected that a simulation might finish before the last step if it encounters an EXIT keyword inside of an executed ACTIONX statement.
With this change we will also write an RSM file in this case. Such a file was missing before.