Navigator: Use hysteresis for neutral gimbal command delay + some refactoring #25598
+44
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
I came across #25551 too late, but realized it's the implementation of a hysteresis/delay and there might be an opportunity to simplify the navigator for better readability, so I’m suggesting this follow-up.
Solution
hrt_absolute_time()
calls which all have an insignificantly different timestamp as a result and reuse a loop timestamp instead.Changelog Entry
Test coverage
Not tested, it should be a pure refactor. The thing that would be nicest to verify is that I used the hysteresis correctly.