Add back CANNODE_NODE_ID for setting a static node ID #25669
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Oct 1, 2025
dagar
reviewed
Oct 1, 2025
| int32_t cannode_node_id = 0; | ||
| param_get(param_find("CANNODE_NODE_ID"), &cannode_node_id); | ||
|
|
||
| if (node_id == 0 && cannode_node_id > 0 && cannode_node_id <= 127) { |
There was a problem hiding this comment.
At a minimum we should probably print an error if the node ID value isn't valid.
AlexKlimaj
commented
Oct 1, 2025
| cannode_node_id = 0; | ||
| } | ||
|
|
||
| // Assign the static node ID if no dynamic allocation is used. Do wen't override a valid node ID from the bootloader? |
There was a problem hiding this comment.
This setup will use the dynamic ID from the bootloader, do we want to override it?
There was a problem hiding this comment.
Yes I think if the user has specified a static node ID via CANNODE_NODE_ID and it does not match the NodeID from the shared memory then we need to override it, print a warning, and update the value in shared memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back the CANNODE_NODE_ID param for setting a static node ID on cannodes. This will need careful testing as the last time I dove into this, ran into too many edge cases that could prevent a node from booting.