Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 4, 2025

  • Analyzed the issue: CAN node releases include .px4 files instead of .uavcan.bin files
  • Identified that the build system creates both .px4 files and .uavcan.bin files for CAN nodes
  • Found the packaging logic in cmake/package.cmake and CAN node build logic in src/drivers/bootloaders/CMakeLists.txt
  • Located that uavcan.bin files are created by make_can_boot_descriptor.py script
  • Examined current CPACK install commands to understand what gets packaged
  • Modified packaging script to include .uavcan.bin files for CAN nodes in organized directories
  • Updated GitHub workflow to include .uavcan.bin files in releases
  • Tested the implementation with a mock directory structure
  • Updated English documentation to reflect the new release structure
  • Fixed: Excluded .px4 files for CAN node builds (only .uavcan.bin files are packaged)
  • Fixed: Reverted Korean documentation (auto-generated, should not be manually updated)
  • Verified the solution addresses all requirements and feedback

Changes made:

  1. Modified Tools/ci/package_build_artifacts.sh:

    • Added logic to detect and package .uavcan.bin files
    • Created organized directory structure: artifacts/can_nodes/{board_name}/
    • NEW: Exclude .px4 files for CAN node builds - only non-CAN builds get .px4 files
    • Added support for both main .uavcan.bin files and deploy directory .bin files
    • Enabled globstar for proper recursive file matching
  2. Updated .github/workflows/build_all_targets.yml:

    • Modified release upload to include both .px4 and .uavcan.bin files
    • .uavcan.bin files will be in named subdirectories for easy identification
  3. Updated English documentation only:

    • Added clear explanation of the new release structure
    • Provided examples showing how CAN node files are organized in releases
    • Clarified which files users should download for flashing CAN nodes
    • Reverted Korean docs - these are auto-generated

Solution verified:
✅ CAN nodes get ONLY .uavcan.bin files (no .px4 files)
✅ Regular flight controllers get their .px4 files
✅ Files organized in named folders (can_nodes/{board_name}/)
✅ Both main .uavcan.bin files and deploy directory .bin files included
✅ English documentation updated, Korean docs not touched

Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug] Released for CAN nodes are the wrong binaries</issue_title>
<issue_description>### Describe the bug

The release binaries for CAN nodes are the .px4 files which cannot be flashed. They need to be the uavcan.bin files. Ideally in their own named folders.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #25621

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] [Bug] Released for CAN nodes are the wrong binaries Fix CAN node release packaging: Include .uavcan.bin files in organized directories Oct 4, 2025
@Copilot Copilot AI requested a review from dakejahl October 4, 2025 00:33
Copilot finished work on behalf of dakejahl October 4, 2025 00:33
Copy link
Contributor

@dakejahl dakejahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you should only update the english docs, the others are generated. You should not upload the .px4 files for the cannode builds, only the .uavcan.bin files.

Copy link
Contributor Author

Copilot AI commented Oct 10, 2025

@copilot you should only update the english docs, the others are generated. You should not upload the .px4 files for the cannode builds, only the .uavcan.bin files.

Fixed in commit 49fd22b:

  • Reverted Korean docs (docs/ko/dronecan/px4_cannode_fw.md) - only English docs updated
  • Modified packaging script to exclude .px4 files for CAN node builds - CAN nodes now get only .uavcan.bin files, while regular flight controllers still get .px4 files

Copilot finished work on behalf of dakejahl October 10, 2025 05:45
@Copilot Copilot AI requested a review from dakejahl October 10, 2025 05:45
@dakejahl dakejahl closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Released for CAN nodes are the wrong binaries

2 participants