tools: add script to run clang-tidy to fix uninitialized variables

[dakejahl]

Dependencies

  sudo apt install clang clang-tidy clang-tools
  sudo ln -s /usr/bin/clang-apply-replacements-14 /usr/bin/clang-apply-replacements

Note: The version number (14) may vary depending on your Ubuntu version. The script will detect the installed version and provide the correct symlink command if needed

Usage

make px4_sitl_default-clang
./Tools/clang_tidy_fix_uninitialized.py src/modules/fw_att_control

[hamishwillee]

Perhaps

Suggested change

	Fix uninitialized member variables using clang-tidy.
	Initializes uninitialized member variables to 0, using clang-tidy.

[hamishwillee]

I'm going to leave the rest of the reviews to the developer team who will actually use this. It's a good idea though, and you might want to update the contribution section of the docs to point to this (and other) tools that are useful.

[dakejahl]

it zero initializes primitives and default constructs classes

[hamishwillee]

Perhaps say that then. If you aren't sure that most developers will know why and when you want to do that, perhaps add a note on that too. This is why I suggested adding a link to the contribution section - so that people can find it and know when to use it. Otherwise they'll probably end up manually updating.

[dakejahl]

I mostly opened this PR just to share the solution with Silvan and Mahima, since they just ran into a real bug caused by this. I'll probably leave this open until if/when we decide to fix all of our files.

[hamishwillee]

Fair enough. I think it might be interesting to add it to CI as a "test" to show uninitialized variables and offer to fix them - give people a chance to spot these cases over time rather than do it as a big-bang. Reasoning being that it's a lot less risky to fix small things than big things.