included evaluated_at properties in $feature_flag_called events
#321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Nov 21, 2025
| val flags: Map<String, FeatureFlag>? = null, | ||
| val quotaLimited: List<String>? = null, | ||
| val requestId: String?, | ||
| val evaluatedAt: Long?, |
Member
There was a problem hiding this comment.
add the @property comment docs above, also for requestId just noticed its missing
dustinbyrne
approved these changes
Nov 24, 2025
Contributor
dustinbyrne
left a comment
dustinbyrne
left a comment
There was a problem hiding this comment.
Looks good! I left a couple of comments below. Also needs CHANGELOG entries.
| // value should never be nullabe anyway | ||
| props["\$feature_flag_response"] = value ?: "" | ||
| props["\$feature_flag_request_id"] = requestId ?: "" | ||
| props["\$feature_flag_evaluated_at"] = evaluatedAt ?: "" |
Contributor
There was a problem hiding this comment.
This is either a long or a string depending on whether or not evaluatedAt is null. Does this introduce a chance of creating the $feature_flag_evaluated_at property definition with the wrong type? If so, maybe we only write it when it's non-null
Suggested change
| props["\$feature_flag_evaluated_at"] = evaluatedAt ?: "" | |
| evaluatedAt?.let { props["\$feature_flag_evaluated_at"] = it } |
Contributor
Author
There was a problem hiding this comment.
d'oh; you're so right
| // no-op by default | ||
| } | ||
|
|
||
| public fun getRequestId( |
Contributor
There was a problem hiding this comment.
There's a PostHogFeatureFlagsInterface implemented somewhere in the tests which will need the new methods.
dmarticus
changed the title
evaluated_at properties in $feature_flag_called events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
See PostHog/posthog#41824 for context\
💚 How did you test it?
New unit tests
📝 Checklist