Update manylinux containers to use gcc-toolset-13 #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayhawk-commits
added
test:hipcub
Contributor
Author
|
Compilation of ROCm that was using this docker successfully passed. https://github.com/ROCm/TheRock/actions/runs/18395921549/job/52415357417 |
stellaraccident
approved these changes
Oct 10, 2025
Collaborator
stellaraccident
left a comment
stellaraccident
left a comment
There was a problem hiding this comment.
Can you please update the PR description prior to landing with the motivation for this (bug in binutils, etc).
Collaborator
|
When are you planning to bump the container hash to use these? |
Contributor
Author
Today with PR #1746 |
jayhawk-commits
added a commit
that referenced
this pull request
Oct 17, 2025
- Update workflows to use new manylinux docker image produced by #1745 - For Linux, turn on `DYNAMIC_ARCH` for OpenBLAS build to resolve #83. - `DYNAMIC_ARCH` support does not exist for MSVC and multi-arch support for Windows seems shoddy overall. [Reference 1](OpenMathLib/OpenBLAS#2826 (comment)) and [Reference 2](OpenMathLib/OpenBLAS#3985) - Remove usage of f2c version of an older lapack as it is considered fallback option. [Reference](OpenMathLib/OpenBLAS#4318 (comment)) - Patch amd-llvm compiler to be able to find stdc++ from gcc-toolset-13 during link time.
jharryma
pushed a commit
that referenced
this pull request
Nov 5, 2025
- To address #1738 and #83 - gcc-toolset-12 ships with binutils 2.38, and this version has a bug exposed by `DYNAMIC_ARCH` turned ON for OpenBLAS. See OpenMathLib/OpenBLAS#3708 - TheRock needs that `DYNAMIC_ARCH` OpenBLAS flag on to support testing of BLAS and SOLVER libraries for cases where test machine's CPU is different than the build machine. The CPU is used for calculating results, and comparing against the test result values produced by the GPU. - gcc-toolset-13 has a version of binutils that is fixed for this use case.
jharryma
pushed a commit
that referenced
this pull request
Nov 5, 2025
- Update workflows to use new manylinux docker image produced by #1745 - For Linux, turn on `DYNAMIC_ARCH` for OpenBLAS build to resolve #83. - `DYNAMIC_ARCH` support does not exist for MSVC and multi-arch support for Windows seems shoddy overall. [Reference 1](OpenMathLib/OpenBLAS#2826 (comment)) and [Reference 2](OpenMathLib/OpenBLAS#3985) - Remove usage of f2c version of an older lapack as it is considered fallback option. [Reference](OpenMathLib/OpenBLAS#4318 (comment)) - Patch amd-llvm compiler to be able to find stdc++ from gcc-toolset-13 during link time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DYNAMIC_ARCHturned ON for OpenBLAS. Seelibopenblasunusable when built with binutils 2.38 on Ubuntu 18.04 and 20.04 OpenMathLib/OpenBLAS#3708DYNAMIC_ARCHOpenBLAS flag on to support testing of BLAS and SOLVER libraries for cases where test machine's CPU is different than the build machine. The CPU is used for calculating results, and comparing against the test result values produced by the GPU.