Skip to content

Update manylinux containers to use gcc-toolset-13 #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

Update manylinux containers to use gcc-toolset-13 #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
128728e
Update manylinux containers to use gcc-toolset-13
jayhawk-commits Oct 9, 2025
682393a
Update PATHs to point to gcc 13
jayhawk-commits Oct 9, 2025
a294926
more PATH changes based on test output
jayhawk-commits Oct 9, 2025
f58c925
Add lib to PATHs as gcc seems to be in there, not lib64
jayhawk-commits Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions dockerfiles/build_manylinux_rccl_x86_64.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ RUN ./install_googletest.sh "${GOOGLE_TEST_VERSION}" && rm -rf /install-googlete
RUN yum install -y epel-release && \
yum remove -y gcc-toolset* && \
yum install -y \
gcc-toolset-12-binutils \
gcc-toolset-12-gcc \
gcc-toolset-12-gcc-c++ \
gcc-toolset-12-gcc-gfortran \
gcc-toolset-12-libatomic-devel \
gcc-toolset-12-libstdc++-devel \
gcc-toolset-13-binutils \
gcc-toolset-13-gcc \
gcc-toolset-13-gcc-c++ \
gcc-toolset-13-gcc-gfortran \
gcc-toolset-13-libatomic-devel \
gcc-toolset-13-libstdc++-devel \
patchelf \
vim-common \
git-lfs \
Expand All @@ -89,12 +89,16 @@ RUN pip install dvc[s3]==3.62.0 && \
######## Enable GCC Toolset and verify ########
# This is a subset of what is typically sourced in the gcc-toolset enable
# script.
# The base manylinux container has references to its gcc-toolset in its PATHs,
# clean up LIBRARY_PATH and LD_LIBRARY_PATH since we yum remove that version.
# -- Predefine variables to avoid Dockerfile linting warnings --
# Docker requires environment variables to be defined before reuse.
ENV LIBRARY_PATH=""
ENV PATH="/opt/rh/gcc-toolset-12/root/usr/bin:${PATH}"
ENV LIBRARY_PATH="/opt/rh/gcc-toolset-12/root/usr/lib64:${LIBRARY_PATH}"
ENV LD_LIBRARY_PATH="/opt/rh/gcc-toolset-12/root/usr/lib64:${LD_LIBRARY_PATH}"
ENV LD_LIBRARY_PATH=""
ENV DEVTOOLSET_ROOTPATH="/opt/rh/gcc-toolset-13/root"
ENV PATH="/opt/rh/gcc-toolset-13/root/usr/bin:${PATH}"
ENV LIBRARY_PATH="/opt/rh/gcc-toolset-13/root/usr/lib64:/opt/rh/gcc-toolset-13/root/usr/lib:${LIBRARY_PATH}"
ENV LD_LIBRARY_PATH="/opt/rh/gcc-toolset-13/root/usr/lib64:/opt/rh/gcc-toolset-13/root/usr/lib:${LD_LIBRARY_PATH}"

######## Enable GCC Toolset and verify ########
RUN which gcc && gcc --version && \
Expand Down
22 changes: 13 additions & 9 deletions dockerfiles/build_manylinux_x86_64.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@ RUN ./install_googletest.sh "${GOOGLE_TEST_VERSION}" && rm -rf /install-googlete
RUN yum install -y epel-release && \
yum remove -y gcc-toolset* && \
yum install -y \
gcc-toolset-12-binutils \
gcc-toolset-12-gcc \
gcc-toolset-12-gcc-c++ \
gcc-toolset-12-gcc-gfortran \
gcc-toolset-12-libatomic-devel \
gcc-toolset-12-libstdc++-devel \
gcc-toolset-13-binutils \
gcc-toolset-13-gcc \
gcc-toolset-13-gcc-c++ \
gcc-toolset-13-gcc-gfortran \
gcc-toolset-13-libatomic-devel \
gcc-toolset-13-libstdc++-devel \
patchelf \
vim-common \
git-lfs \
Expand All @@ -81,12 +81,16 @@ RUN pip install dvc[s3]==3.62.0 && \
######## Enable GCC Toolset and verify ########
# This is a subset of what is typically sourced in the gcc-toolset enable
# script.
# The base manylinux container has references to its gcc-toolset in its PATHs,
# clean up LIBRARY_PATH and LD_LIBRARY_PATH since we yum remove that version.
# -- Predefine variables to avoid Dockerfile linting warnings --
# Docker requires environment variables to be defined before reuse.
ENV LIBRARY_PATH=""
ENV PATH="/opt/rh/gcc-toolset-12/root/usr/bin:${PATH}"
ENV LIBRARY_PATH="/opt/rh/gcc-toolset-12/root/usr/lib64:${LIBRARY_PATH}"
ENV LD_LIBRARY_PATH="/opt/rh/gcc-toolset-12/root/usr/lib64:${LD_LIBRARY_PATH}"
ENV LD_LIBRARY_PATH=""
ENV DEVTOOLSET_ROOTPATH="/opt/rh/gcc-toolset-13/root"
ENV PATH="/opt/rh/gcc-toolset-13/root/usr/bin:${PATH}"
ENV LIBRARY_PATH="/opt/rh/gcc-toolset-13/root/usr/lib64:/opt/rh/gcc-toolset-13/root/usr/lib:${LIBRARY_PATH}"
ENV LD_LIBRARY_PATH="/opt/rh/gcc-toolset-13/root/usr/lib64:/opt/rh/gcc-toolset-13/root/usr/lib:${LD_LIBRARY_PATH}"

######## Enable GCC Toolset and verify ########
RUN which gcc && gcc --version && \
Expand Down
Loading