-
Notifications
You must be signed in to change notification settings - Fork 22
Enable default user drift #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
burythehammer
wants to merge
33
commits into
main
Choose a base branch
from
fix/enable-default-user-drift-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set false explicitly
…hensive check for all transitions
burythehammer
commented
Nov 13, 2025
| - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveTransitGatewayAttachment_CRUDI"' | ||
|
|
||
| # ===== WAVE 1: Critical smoke tests for PR changes ===== | ||
| # These test our direct code changes and must pass first |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have temporarily restructured the smoke tests so I don't spin up more than I need. This will go back to the old structure afterwards
… to remove the override
…ted to fix hash drift issues
… identify region type
…ate, and keeping value always in state
…for pro subscriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
rediscloud_active_active_subscription_database: Fixed drift detection forenable_default_userin region overrides. Regions now correctly inherit fromglobal_enable_default_userwhen not explicitly set, eliminating spurious diffs.rediscloud_active_active_subscription_database: Fixed drift detection forglobal_data_persistence. This field now correctly tracks API-returned values without causing unexpected diffs.