-
Notifications
You must be signed in to change notification settings - Fork 22
Enable default user drift #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
burythehammer
wants to merge
33
commits into
main
Choose a base branch
from
fix/enable-default-user-drift-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2015bd3
fix: removing override for default users so that users do not have to…
burythehammer d0faf94
fix: use API value for global_enable_default_user comparison
burythehammer 63c29fe
fix: source_ips showing erronous drift when not in same order
burythehammer b7b728d
chore: detects read mode and acts accordingly, and workflow changes f…
burythehammer d00272f
docs: various docs changes, bumping go.mod, adding new action to gh a…
burythehammer 9e26f2d
fix: set global data persistence to computed so state tracks correctly
burythehammer 0b8262f
test: improving test coverage for enable default user
burythehammer 67b3ef6
fix: provide card numbers
burythehammer 39fbc0e
test: remove region from fixture
burythehammer 0f0c437
fix: cleaning up regions on subscription test
burythehammer e1c000e
chore: adding debugging to work out aws account id issue
burythehammer 51d6ad9
test: removing account id assertion for non BYOC accounts and removin…
burythehammer fcafeea
test: redis_version 8.0 doesn't exist, fixing test version
burythehammer ebcec58
test: restructuring enable default user tests to have a 4 step compre…
burythehammer 0701340
fix: remove qpf module hardcoded validation
burythehammer dbd6516
chore: adding debug logs
burythehammer f41e1de
chore: small formatting fix
burythehammer fcc3960
fix: when removing regional default_user then send the global default…
burythehammer c489f09
chore: changing test fixture naming logic and moving field to a compu…
burythehammer dd9c951
fix: trying custom hash for set to prevent drift, as only name should…
burythehammer 96ec3cc
fix: Read enable_default_user from config, not state
burythehammer fd52aad
fix: custom force update function when hashes are different
burythehammer 0812829
fix: reverting computed true and custom forcediffs
burythehammer bfad312
fix: new approach - using DiffSuppressFunc instead of messing with st…
burythehammer 47ff5dd
fix: update needs to decide from rawconfig what to send
burythehammer a7375fd
test: explicit redis 7 and 8 crud tests for backwards compatibility
burythehammer 4bbf24e
test: explicit redis 7 and 8 crud tests for backwards compatibility, …
burythehammer 995d4bc
fix: making diffsuppress smarter so compute: true is not required
burythehammer 36088e5
test: update fixtures missing redis versions
burythehammer 1b800ef
test: moving redis version to correct level
burythehammer c29d7ed
fix: redis 8 modules correctly handled by active active databases in …
burythehammer dc0ad24
chore: seeing whether the typeset hash has caused our issues
burythehammer fb07fdf
test: fixing test fixture
burythehammer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: 'Run Acceptance Tests' | ||
| description: 'Run acceptance tests with validation that tests actually ran' | ||
| inputs: | ||
| test_pattern: | ||
| description: 'Test pattern to pass to -run flag' | ||
| required: true | ||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: Run tests | ||
| shell: bash | ||
| env: | ||
| TEST_PATTERN: ${{ inputs.test_pattern }} | ||
| run: | | ||
| set -o pipefail | ||
| EXECUTE_TESTS=true make testacc TESTARGS="-run=\"$TEST_PATTERN\"" 2>&1 | tee test_output.txt | ||
| if ! grep -q "=== RUN" test_output.txt; then | ||
| echo "ERROR: No tests matched the pattern. Please check the -run argument." | ||
| exit 1 | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
provider/activeactive/testdata/enable_default_user_step1_global_true_mixed.tf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| # Template signature: fmt.Sprintf(template, subscription_name, database_name, password) | ||
| locals { | ||
| subscription_name = "%s" | ||
| database_name = "%s" | ||
| password = "%s" | ||
| } | ||
|
|
||
| data "rediscloud_payment_method" "card" { | ||
| card_type = "Visa" | ||
| last_four_numbers = "5556" | ||
| } | ||
|
|
||
| resource "rediscloud_active_active_subscription" "example" { | ||
| name = local.subscription_name | ||
| payment_method_id = data.rediscloud_payment_method.card.id | ||
| cloud_provider = "AWS" | ||
|
|
||
| creation_plan { | ||
| dataset_size_in_gb = 1 | ||
| quantity = 1 | ||
|
|
||
| region { | ||
| region = "us-east-1" | ||
| networking_deployment_cidr = "10.0.0.0/24" | ||
| write_operations_per_second = 1000 | ||
| read_operations_per_second = 1000 | ||
| } | ||
|
|
||
| region { | ||
| region = "us-east-2" | ||
| networking_deployment_cidr = "10.0.1.0/24" | ||
| write_operations_per_second = 1000 | ||
| read_operations_per_second = 1000 | ||
| } | ||
|
|
||
| region { | ||
| region = "eu-west-2" | ||
| networking_deployment_cidr = "10.2.0.0/24" | ||
| write_operations_per_second = 1000 | ||
| read_operations_per_second = 1000 | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource "rediscloud_active_active_subscription_database" "example" { | ||
| subscription_id = rediscloud_active_active_subscription.example.id | ||
| name = local.database_name | ||
| memory_limit_in_gb = 1 | ||
|
|
||
| # Global enable_default_user is true | ||
| global_enable_default_user = true | ||
| global_password = local.password | ||
|
|
||
| # us-east-1: explicitly set to true (matches global) | ||
| override_region { | ||
| name = "us-east-1" | ||
| enable_default_user = true | ||
| } | ||
|
|
||
| # us-east-2: explicitly set to false (differs from global) | ||
| override_region { | ||
| name = "us-east-2" | ||
| enable_default_user = false | ||
| } | ||
|
|
||
| # eu-west-2: NOT set (inherits from global=true) | ||
| override_region { | ||
| name = "eu-west-2" | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have temporarily restructured the smoke tests so I don't spin up more than I need. This will go back to the old structure afterwards