-
Notifications
You must be signed in to change notification settings - Fork 50
TBI - Replace service key (UAA/OAuth2) based connections with re-entrance tickets #3693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 592024a The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IainSAP, here are my suggestions.
packages/odata-service-inquirer/src/translations/odata-service-inquirer.i18n.json
Outdated
Show resolved
Hide resolved
Back to draft it seems we still need to support UAA with credentials from the CLI without browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for backend-proxy-middleware
…nto 3578/remove_service_key_usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good
Mainly checked abap deployment gen and sub modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look appropriate.
As clarified offline this is backward compatible for system types S4HC
or BTP
-> ABAPCloud
. No migration is necessary.
Covered by tests
changeset 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset exists
- test coverage ok
- review comments have been addressed
- did NOT test manually
- only checked backend-proxy-middleware
|
…chart_on_list_v4 * origin/main: chore: apply latest changesets feat(fpm-writer): table building block custom columns (#3665) chore: apply latest changesets fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706) chore: apply latest changesets fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times. (#3683) chore: apply latest changesets update axios version (#3732) chore: apply latest changesets fix(fiori-annotation-api): wrong origin range (#3729) chore: apply latest changesets TBI - Replace service key (UAA/OAuth2) based connections with re-entrance tickets (#3693) chore: apply latest changesets fix: smartlinks target prompt (#3643) chore: apply latest changesets feat: Add ADP Generator Cloud Foundry prompting code (#3518)
#3578
@sap-ux/store
) categorization asBTP
orS4HC
withAbap Cloud
as the distinction was being made based on auth type which does not hold true.@sap-ux/odata-service-inquirer
isSCP
property in existing yamls for backwards compatibility (preview middleware) however new apps that connect to cloud systems will not always useauthenticationType: reentranceTicket
user()
from UAA with the endpoint/sap/bc/adt/core/http/systeminformation
which also contains the logged on user info. However this will be the Abap user not the UAA (IDP) user.