[BugFix] Fix mv rewrite bugs with IllegalStateException #63655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satanson
approved these changes
Sep 30, 2025
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
@mergify rebase |
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
LiShuMing
force-pushed
the
fix_mv_rewrite_bugs2
branch
from
be8d6a0 to
1dc7bdc
Compare
✅ Branch has been successfully rebased |
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 41 / 46 (89.13%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kangkaisen
approved these changes
Oct 9, 2025
|
@Mergifyio backport branch-4.0 |
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 7ed48a7) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java
23 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 7ed48a7) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 7ed48a7) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java
This was referenced Oct 9, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 7ed48a7) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java
23 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 9, 2025
) (#63856) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 9, 2025
) (#63857) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 9, 2025
) (#63855) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 10, 2025
) (#63858) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Oct 16, 2025
) (#63858) Signed-off-by: shuming.li <[email protected]> Co-authored-by: shuming.li <[email protected]> (cherry picked from commit 31894ed)
Closed
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Fix mv rewrite with possible exceptions:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Ensures logical properties are derived before using output columns to fix MV rewrite ISE; adds next-run scheduling and logging to MV refresh, safer partition dropping, bounded partition list string, and tests.
OptExpressionoutput columns viaMvUtils.getOutputColumnsto preventIllegalStateException.MvUtils.getOutputColumnshelper; update callers inMaterializedViewRewriter.BaseMVRefreshProcessor.generateNextTaskRunIfNeeded()and invoke it fromMVTaskRunProcessoron success; implement in PCT/IVM processors (respect kill/hasNext conditions).MVPCTRefreshPartitioner.nameToPartition.PCellSortedSetfixes: correctlimit()logic; compacttoString()with prefix...suffix capped byConfig.max_mv_task_run_meta_message_values_length.PCellSortedSetTestand SQL tests for MV rewrite bugfix and behavior.Written by Cursor Bugbot for commit be8d6a0. This will update automatically on new commits. Configure here.