Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2025

Why I'm doing:

Fix mv rewrite with possible exceptions:

520ms|    [MV TRACE] [REWRITE TF_MV_AGGREGATE_JOIN_PUSH_DOWN_RULE] [InMemo:true] mv rewrite exception, exception message:java.lang.IllegalStateException
"	at com.google.common.base.Preconditions.checkState(Preconditions.java:496)"
"	at com.starrocks.sql.optimizer.OptExpression.getOutputColumns(OptExpression.java:147)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.MaterializedViewRewriter.getUnionRewriteQueryCompensation(MaterializedViewRewriter.java:1753)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.MaterializedViewRewriter.doUnionRewrite(MaterializedViewRewriter.java:1818)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.MaterializedViewRewriter.tryUnionRewrite(MaterializedViewRewriter.java:1812)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.MaterializedViewRewriter.tryRewriteForRelationMapping(MaterializedViewRewriter.java:1324)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.MaterializedViewRewriter.rewriteComplete(MaterializedViewRewriter.java:758)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.MaterializedViewRewriter.doRewrite(MaterializedViewRewriter.java:536)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.common.AggregatePushDownUtils.doRewritePushDownAgg(AggregatePushDownUtils.java:86)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter$PostVisitor.visitLogicalTableScan(AggregatedMaterializedViewPushDownRewriter.java:473)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter$PostVisitor.visitLogicalTableScan(AggregatedMaterializedViewPushDownRewriter.java:247)"
"	at com.starrocks.sql.optimizer.operator.logical.LogicalScanOperator.accept(LogicalScanOperator.java:222)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.processPost(AggregatedMaterializedViewPushDownRewriter.java:597)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.lambda$process$0(AggregatedMaterializedViewPushDownRewriter.java:608)"
"	at java.base/java.util.Optional.map(Optional.java:265)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.process(AggregatedMaterializedViewPushDownRewriter.java:608)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter$PostVisitor.visitLogicalJoin(AggregatedMaterializedViewPushDownRewriter.java:297)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter$PostVisitor.visitLogicalJoin(AggregatedMaterializedViewPushDownRewriter.java:247)"
"	at com.starrocks.sql.optimizer.operator.logical.LogicalJoinOperator.accept(LogicalJoinOperator.java:227)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.processPost(AggregatedMaterializedViewPushDownRewriter.java:597)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.lambda$process$0(AggregatedMaterializedViewPushDownRewriter.java:608)"
"	at java.base/java.util.Optional.map(Optional.java:265)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.process(AggregatedMaterializedViewPushDownRewriter.java:608)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.processChildren(AggregatedMaterializedViewPushDownRewriter.java:579)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.lambda$process$0(AggregatedMaterializedViewPushDownRewriter.java:608)"
"	at java.base/java.util.Optional.map(Optional.java:265)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.process(AggregatedMaterializedViewPushDownRewriter.java:608)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.AggregatedMaterializedViewPushDownRewriter.doRewrite(AggregatedMaterializedViewPushDownRewriter.java:80)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.rule.BaseMaterializedViewRewriteRule.doTransform(BaseMaterializedViewRewriteRule.java:211)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.rule.BaseMaterializedViewRewriteRule.doTransform(BaseMaterializedViewRewriteRule.java:162)"
"	at com.starrocks.sql.optimizer.rule.transformation.materialization.rule.BaseMaterializedViewRewriteRule.transform(BaseMaterializedViewRewriteRule.java:100)"
"	at com.starrocks.sql.optimizer.task.ApplyRuleTask.execute(ApplyRuleTask.java:95)"
"	at com.starrocks.sql.optimizer.task.SeriallyTaskScheduler.executeTasks(SeriallyTaskScheduler.java:65)"
"	at com.starrocks.sql.optimizer.Optimizer.memoOptimize(Optimizer.java:955)"
"	at com.starrocks.sql.optimizer.Optimizer.optimizeByCost(Optimizer.java:290)"
"	at com.starrocks.sql.optimizer.Optimizer.optimize(Optimizer.java:214)"
"	at com.starrocks.sql.StatementPlanner.createQueryPlan(StatementPlanner.java:300)"
"	at com.starrocks.sql.StatementPlanner.plan(StatementPlanner.java:143)"
"	at com.starrocks.sql.StatementPlanner.plan(StatementPlanner.java:104)"
"	at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:606)"
"	at com.starrocks.qe.ConnectProcessor.handleQuery(ConnectProcessor.java:392)"
"	at com.starrocks.qe.ConnectProcessor.dispatch(ConnectProcessor.java:592)"
"	at com.starrocks.qe.ConnectProcessor.processOnce(ConnectProcessor.java:930)"
"	at com.starrocks.mysql.nio.ReadListener.lambda$handleEvent$0(ReadListener.java:71)"
"	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)"
"	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)"
"	at java.base/java.lang.Thread.run(Thread.java:829)"

What I'm doing:

  • ensure optExpression has derived logical property, otherwise OptExpression.getOutputColumns will fail
        MvUtils.deriveLogicalProperty(optExpression);

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

Note

Ensures logical properties are derived before using output columns to fix MV rewrite ISE; adds next-run scheduling and logging to MV refresh, safer partition dropping, bounded partition list string, and tests.

  • MV Rewrite/Optimizer:
    • Derive logical property for newly built agg nodes and when accessing OptExpression output columns via MvUtils.getOutputColumns to prevent IllegalStateException.
    • Add MvUtils.getOutputColumns helper; update callers in MaterializedViewRewriter.
  • MV Refresh Scheduler:
    • Add BaseMVRefreshProcessor.generateNextTaskRunIfNeeded() and invoke it from MVTaskRunProcessor on success; implement in PCT/IVM processors (respect kill/hasNext conditions).
    • Improve force-refresh partition dropping: use partitioner for partitioned MVs; handle non-partitioned with single drop and rebuild.
    • Promote partition drop helper to public in MVPCTRefreshPartitioner.
    • Add success/failure logs around refresh.
  • Catalog/Partition utilities:
    • Guard range/list partition maps to skip names absent in nameToPartition.
  • Common utils:
    • PCellSortedSet fixes: correct limit() logic; compact toString() with prefix...suffix capped by Config.max_mv_task_run_meta_message_values_length.
  • Tests/SQL:
    • Add PCellSortedSetTest and SQL tests for MV rewrite bugfix and behavior.

Written by Cursor Bugbot for commit be8d6a0. This will update automatically on new commits. Configure here.


This is an automatic backport of pull request #63655 done by [Mergify](https://mergify.com).

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 7ed48a7)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java
#	fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java
@mergify mergify bot added the conflicts label Oct 9, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Oct 9, 2025

Cherry-pick of 7ed48a7 has failed:

On branch mergify/bp/branch-3.4/pr-63655
Your branch is up to date with 'origin/branch-3.4'.

You are currently cherry-picking commit 7ed48a790a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/catalog/OlapTable.java
	modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTRefreshPartitioner.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewPushDownRewriter.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
	new file:   fe/fe-core/src/test/java/com/starrocks/sql/common/PCellSortedSetTest.java
	new file:   test/sql/test_materialized_view_rewrite/R/test_mv_rewrite_bugfix2.sql
	new file:   test/sql/test_materialized_view_rewrite/T/test_mv_rewrite_bugfix2.sql

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java
	deleted by us:   fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 9, 2025 11:25
@mergify mergify bot closed this Oct 9, 2025
auto-merge was automatically disabled October 9, 2025 11:25

Pull request was closed

@mergify
Copy link
Contributor Author

mergify bot commented Oct 9, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify
Copy link
Contributor Author

mergify bot commented Oct 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for 5b8b1c4.

🟢 All jobs passed!

But CI Insights is watching 👀

Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing reopened this Oct 9, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) October 9, 2025 11:39
@wanpengfei-git wanpengfei-git merged commit 8e1753d into branch-3.4 Oct 9, 2025
41 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-63655 branch October 9, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants