-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[BugFix] Fix mv rewrite bugs with IllegalStateException (backport #63655) #63857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 7ed48a7) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/scheduler/MVTaskRunProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/BaseMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/MVPCTBasedRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/scheduler/mv/ivm/MVIVMBasedMVRefreshProcessor.java # fe/fe-core/src/main/java/com/starrocks/sql/common/PCellSortedSet.java
|
Cherry-pick of 7ed48a7 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
🧪 CI InsightsHere's what we observed from your CI run for 5b8b1c4. 🟢 All jobs passed!But CI Insights is watching 👀 |
Signed-off-by: shuming.li <[email protected]>
Why I'm doing:
Fix mv rewrite with possible exceptions:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Ensures logical properties are derived before using output columns to fix MV rewrite ISE; adds next-run scheduling and logging to MV refresh, safer partition dropping, bounded partition list string, and tests.
OptExpressionoutput columns viaMvUtils.getOutputColumnsto preventIllegalStateException.MvUtils.getOutputColumnshelper; update callers inMaterializedViewRewriter.BaseMVRefreshProcessor.generateNextTaskRunIfNeeded()and invoke it fromMVTaskRunProcessoron success; implement in PCT/IVM processors (respect kill/hasNext conditions).MVPCTRefreshPartitioner.nameToPartition.PCellSortedSetfixes: correctlimit()logic; compacttoString()with prefix...suffix capped byConfig.max_mv_task_run_meta_message_values_length.PCellSortedSetTestand SQL tests for MV rewrite bugfix and behavior.Written by Cursor Bugbot for commit be8d6a0. This will update automatically on new commits. Configure here.
This is an automatic backport of pull request #63655 done by [Mergify](https://mergify.com).