Skip to content

Conversation

timkeo
Copy link
Collaborator

@timkeo timkeo commented Aug 14, 2024

Description

The logic checking for duplicate "Began" phases with a touch contact was incorrect. The first touch contact will show correctly but successive interactions were filtered out.

Changes made

Corrected the filter logic: to check the GameObject's active state and not just for null: if GO is active (for given touchID) then it's a duplicate.

Testing

Verified the fix locally.

Risk

Minimal risk: only changes the sample, which apparently has been broken for years.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@timkeo timkeo force-pushed the ixsb-1017-fix-touchdevice-sample branch from 6e21421 to d804d99 Compare August 14, 2024 16:37
The logic checking for duplicate "Began" phases with a touch contact was incorrect and has been corrected.
@timkeo timkeo force-pushed the ixsb-1017-fix-touchdevice-sample branch from d804d99 to fae8ea2 Compare August 14, 2024 16:39
@timkeo timkeo requested a review from Pauliusd01 August 14, 2024 16:40
@Pauliusd01
Copy link
Collaborator

Will check this today

@Pauliusd01 Pauliusd01 changed the title FIX: InputDeviceTester only shows first touch contact (IXSB-1017) FIX: InputDeviceTester only shows first touch contact (ISXB-1017) Aug 19, 2024
@Pauliusd01 Pauliusd01 merged commit cf28d7d into develop Aug 19, 2024
77 of 79 checks passed
@Pauliusd01 Pauliusd01 deleted the ixsb-1017-fix-touchdevice-sample branch August 19, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants