Skip to content

Conversation

jamesmcgill
Copy link
Collaborator

@jamesmcgill jamesmcgill commented Sep 9, 2024

Description

Renamed editor Resources directories to PackageResources to fix package validation warnings.

Changes made

Renamed:
InputSystem/Editor/AssetEditor/Resources/ -> InputSystem/Editor/AssetEditor/PackageResources/

InputSystem/Editor/UITKAssetEditor/Resources/ ->
InputSystem/Editor/UITKAssetEditor/PackageResources/

Edited Directory constants in:
InputSystem\Editor\AssetEditor\InputActionTreeView.cs
InputSystem\Editor\UITKAssetEditor\InputActionsEditorConstants.cs
and various uxml files.

Testing

Ran CI jobs.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@jamesmcgill jamesmcgill force-pushed the isx-1440-rename-resource-directory branch from 64933d4 to 7030d56 Compare September 9, 2024 10:02
@jfreire-unity jfreire-unity requested review from jfreire-unity and removed request for jfreire-unity September 9, 2024 10:54
@jamesmcgill jamesmcgill force-pushed the isx-1440-rename-resource-directory branch from 7030d56 to a3ac3ae Compare September 9, 2024 14:21
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekcoh ekcoh requested a review from Pauliusd01 September 11, 2024 19:14
@Pauliusd01
Copy link
Collaborator

Sorry, was busy. Will check this today

@jamesmcgill
Copy link
Collaborator Author

Thanks for the reviews!

@jamesmcgill jamesmcgill merged commit 2f51783 into develop Sep 12, 2024
77 checks passed
@jamesmcgill jamesmcgill deleted the isx-1440-rename-resource-directory branch September 12, 2024 13:35
@jamesmcgill jamesmcgill mentioned this pull request Sep 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants