-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: correct index for limit in book_offers CLI
#6043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
book_offers CLI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6043 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 818 818
Lines 68983 68989 +6
Branches 8246 8241 -5
=======================================
+ Hits 54196 54210 +14
+ Misses 14787 14779 -8
🚀 New features to boost your workflow:
|
|
#6044 is a version of this PR that covers more cases and is broader. We may want to merge this first or go straight to that one, unsure. |
|
@Tapanito are there any additional things that need to be addressed, or is this good to go? |
High Level Overview of Change
This PR fixes an indexing typo in the
book_offersCLI processing. This does not affect the HTTPS/WS RPC processing.It's a fairly straightforward fix - there is a length check on whether the list length is
>= 5, but the5uindex is taken instead of the4uindex (as the last in the list).Context of Change
Reported as a part of the Lending Protocol Attackathon
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
There is a minor fix in the
book_offersCLI. This does not affect the HTTPS/WS RPC processing.Test Plan
CI passes.