[spark] Stop checking if volume to mount in k8s exists locally #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's entirely possible (and not an error) to create a podspec that contains paths to volume-mount that do not exist wherever service_configuration_lib is being invoked from. As long as we ensure that we don't double-add things (which is only a problem due to the way that the env var keys are constructed here), skipping the existence check should be fine.
jfongatyelp
approved these changes
Sep 9, 2024
|
I think is the only place where we might run an executor with these files missing - but the container runtime should be fine with that: it'll simply create empty folders on-host rather than crash(if we want to avoid that, I can update just that callsite to check for file existence) |
nemacysts
changed the title
88manpreet
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's entirely possible (and not an error) to create a podspec that contains paths to volume-mount that do not exist wherever service_configuration_lib is being invoked from.
As long as we ensure that we don't double-add things (which is only a problem due to the way that the env var keys are constructed here), skipping the existence check should be fine.