Skip to content

[spark] Stop checking if volume to mount in k8s exists locally #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

[spark] Stop checking if volume to mount in k8s exists locally #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17abc40
Stop checking if volume to mount in k8s exists locally
nemacysts Sep 9, 2024
85e8e38
Remove another exists check
nemacysts Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions service_configuration_lib/spark_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,12 @@ def _get_k8s_docker_volumes_conf(

for volume in k8s_volumes:
host_path, container_path, mode = volume['hostPath'], volume['containerPath'], volume['mode']
if os.path.exists(host_path) and host_path not in mounted_volumes:
if host_path not in mounted_volumes:
env.update(_get_k8s_volume(host_path, container_path, mode))
mounted_volumes.add(host_path)
else:
log.warning(
f'Path {host_path} does not exist on this host or it has already been mounted.'
' Skipping this bindings.',
f'Path {host_path} has already been mounted. Skipping this binding.',
)
return env

Expand Down
1 change: 0 additions & 1 deletion tests/spark_config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,6 @@ def _get_k8s_base_volumes(self):
"""Helper needed to allow tests to pass in github CI checks."""
return [
volume for volume in spark_config.K8S_BASE_VOLUMES
if os.path.exists(volume['containerPath'])
]

@pytest.fixture
Expand Down