Skip to content

Conversation

hellohawaii
Copy link

Fix a bug in google-cloudrun-docker.yml.

When defining the DOCKER_TAG variable, an extra dollar sign ($) was incorrectly prepended to the ${{ env.REGION }} expression. This caused the shell to misinterpret the variable during expansion.

Specifically, when env.REGION was set to us-central1-c, the shell attempted to expand $us-central1-c. Because the variable $us was undefined, it was replaced with an empty string, resulting in a malformed image tag that started with -central1-c.cThis tag format is invalid according to Docker's naming conventions, which caused the build step to fail.

@Copilot Copilot AI review requested due to automatic review settings August 17, 2025 16:22
@hellohawaii hellohawaii requested review from a team as code owners August 17, 2025 16:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a shell variable expansion bug in the Google Cloud Run Docker deployment workflow where an extra dollar sign was causing incorrect tag generation.

  • Removes redundant $ symbol from the DOCKER_TAG variable definition
  • Prevents shell misinterpretation of GitHub Actions environment variable expansion
  • Ensures proper Docker image tag format for Cloud Run deployments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants