Using suggested MSVC build tools version for latest UE versions #372
Conversation
Alexey31rus
force-pushed
the
suggested-msvc-version
branch
from
106b923 to
1189ccb
Compare
|
We can use this as a quick hack. For a more long-term solution, I'd like to use See https://discord.com/channels/844118704941170688/844121719475535913/1310942558502912001 and previous messages in that thread. I currently have a semi-finished branch that implements this approach, but not ready for PR yet. |
| $windows_os_version = "Windows10SDK" | ||
|
|
||
| # NOTE: See suggested components https://github.com/EpicGames/UnrealEngine/blob/release/Engine/Config/Windows/Windows_SDK.json | ||
| if ($unreal_engine_version.StartsWith("5.4")) |
There was a problem hiding this comment.
$windows_os_version is not set in this branch
There was a problem hiding this comment.
For this branch will be used value from line 68. UE 5.4 still uses Win10SDK. Or are you writing that it is better to explicitly specify value of variable in this branch?
| $vs_args = $vs_args, | ||
| "--add", "Microsoft.VisualStudio.Component.VC.$vs_tools_version.x86.x64", | ||
| "--remove", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", | ||
| "--remove", "Microsoft.VisualStudio.Component.Windows10SDK.20348" |
There was a problem hiding this comment.
Why we need --remove? There is no VS installation yet when our script is executed -> there is nothing to remove.
There was a problem hiding this comment.
Hmm, yes, indeed this component does not appear by default anymore
Alexey31rus
force-pushed
the
suggested-msvc-version
branch
2 times, most recently
from
f47e3b7 to
dfd76ec
Compare
|
Fails on CI because UE version is undefined when we're building |
Alexey31rus
force-pushed
the
suggested-msvc-version
branch
from
dfd76ec to
d2d08e0
Compare
Alexey31rus
force-pushed
the
suggested-msvc-version
branch
from
a934bc4 to
fb01e83
Compare
2 participants
Because on the latest build tools, the compilation of the engine and/or project may fail due to errors. Therefore, we use the recommended version of the build tools for UE 5.4 and 5.5