Skip to content

Conversation

@e-krebs
Copy link
Contributor

@e-krebs e-krebs commented Dec 3, 2024

Summary

this PR leverages what's put in place in #6437 to make it available in vue flavor

EMERCH-1748

@e-krebs e-krebs self-assigned this Dec 3, 2024
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de3b6ea:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@e-krebs e-krebs marked this pull request as ready for review December 3, 2024 17:22
@e-krebs e-krebs requested a review from Haroenv December 3, 2024 17:22
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@e-krebs e-krebs requested a review from Haroenv December 4, 2024 10:26
@e-krebs e-krebs merged commit a09c561 into feat/composition Dec 4, 2024
10 checks passed
@e-krebs e-krebs deleted the feat/composition-vue branch December 4, 2024 16:00
e-krebs added a commit that referenced this pull request Jan 2, 2025
* feat: make vue compatible with composition

* chore: increase vue2 package size 🤏

* chore(lint): allow console.error

* feedback: do not add warning
@e-krebs e-krebs mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants