Skip to content

feat: make composition compatible with vue #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 4, 2024
Merged

feat: make composition compatible with vue #6458

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8635d48
feat: make vue compatible with composition
e-krebs Dec 3, 2024
15cbcd0
chore: increase vue2 package size 🤏
e-krebs Dec 3, 2024
62d704b
chore(lint): allow console.error
e-krebs Dec 3, 2024
de3b6ea
feedback: do not add warning
e-krebs Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundlesize.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
{
"path": "packages/vue-instantsearch/vue2/cjs/index.js",
"maxSize": "20.25 kB"
"maxSize": "20.50 kB"
},
{
"path": "packages/vue-instantsearch/vue3/cjs/index.js",
Expand Down
14 changes: 13 additions & 1 deletion packages/vue-instantsearch/src/components/InstantSearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ export default createInstantSearchComponent({
},
indexName: {
type: String,
required: true,
required: false,
},
compositionID: {
type: String,
required: false,
},
routing: {
default: undefined,
Expand Down Expand Up @@ -101,6 +105,7 @@ export default createInstantSearchComponent({
insightsClient: this.insightsClient,
insights: this.insights,
indexName: this.indexName,
compositionID: this.compositionID,
routing: this.routing,
stalledSearchDelay: this.stalledSearchDelay,
searchFunction: this.searchFunction,
Expand All @@ -111,6 +116,13 @@ export default createInstantSearchComponent({
};
},
render: renderCompat(function (h) {
if (!this.indexName && !this.compositionID) {
// eslint-disable-next-line no-console
console.error(
'Missing either "index-name" or "compositionID" property on "ais-instant-search"'
);
}

return h(
'div',
{
Expand Down
5 changes: 5 additions & 0 deletions packages/vue-instantsearch/src/util/createInstantSearchComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ export const createInstantSearchComponent = (component) =>
indexName(indexName) {
this.instantSearchInstance.helper.setIndex(indexName || '').search();
},
compositionID(compositionID) {
this.instantSearchInstance.helper
.setIndex(compositionID || '')
.search();
},
stalledSearchDelay(stalledSearchDelay) {
// private InstantSearch.js API:
this.instantSearchInstance._stalledSearchDelay = stalledSearchDelay;
Expand Down