Skip to content

Conversation

@MaxWaterhout
Copy link
Collaborator

@MaxWaterhout MaxWaterhout commented Sep 19, 2025

Description

Please include a summary of the changes and the related issue.
Mention if this PR is a bug fix, feature addition, or refactor.

Fixes: #277

Testing

Explain how you tested your changes.

Documentation

  • I have updated the documentation (if necessary)

Additional Notes

Uploading Screencast from 2025-09-26 08-50-38.webm…

@MaxWaterhout MaxWaterhout changed the base branch from milestone/graspnet to main September 19, 2025 14:34
@MaxWaterhout MaxWaterhout changed the base branch from main to milestone/graspnet September 22, 2025 13:18
@MaxWaterhout MaxWaterhout linked an issue Sep 22, 2025 that may be closed by this pull request
4 tasks
@MaxWaterhout MaxWaterhout changed the base branch from milestone/graspnet to main September 24, 2025 08:38
@MaxWaterhout MaxWaterhout changed the base branch from main to milestone/graspnet September 24, 2025 08:39
moveit::planning_interface::MoveGroupInterface::ROBOT_DESCRIPTION,
node->get_namespace())),
moveit_visual_tools(node, "base", "/rviz_markers") {
moveit_visual_tools(node, "franka/fr3_link0", "/rviz_markers") {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be namespaced but i dont know how

@Jelmerdw Jelmerdw marked this pull request as ready for review October 8, 2025 09:46
@Jelmerdw Jelmerdw force-pushed the milestone/graspnet branch 3 times, most recently from 0cfad2f to 1d9f11a Compare October 8, 2025 10:51
@Jelmerdw Jelmerdw closed this Oct 8, 2025
@Jelmerdw Jelmerdw force-pushed the 277-make-a-ros-wrapper branch from 4c10d0c to 1d9f11a Compare October 8, 2025 12:15
@Jelmerdw Jelmerdw reopened this Oct 8, 2025
Signed-off-by: Jelmer de Wolde <[email protected]>
@Jelmerdw Jelmerdw force-pushed the 277-make-a-ros-wrapper branch from 21de58d to 5ccb3a9 Compare October 16, 2025 08:34
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
@Jelmerdw Jelmerdw marked this pull request as draft October 17, 2025 14:37
@Jelmerdw Jelmerdw marked this pull request as ready for review October 21, 2025 14:24
@Jelmerdw Jelmerdw merged commit 4004357 into milestone/graspnet Oct 21, 2025
5 checks passed
@Jelmerdw Jelmerdw deleted the 277-make-a-ros-wrapper branch October 21, 2025 14:30
Jelmerdw added a commit that referenced this pull request Oct 21, 2025
* Make a ros wrapper.

Signed-off-by: Jelmer de Wolde <[email protected]>

* Undo unnecessary changes.

Signed-off-by: Jelmer de Wolde <[email protected]>

* Introduce gui.

Signed-off-by: Jelmer de Wolde <[email protected]>

* Visualize gripper pose in Rviz.

Signed-off-by: Jelmer de Wolde <[email protected]>

* Correct gripper visualization with offset between wrist and tcp.

Signed-off-by: Jelmer de Wolde <[email protected]>

* Add animated visualization of plan.

Signed-off-by: Jelmer de Wolde <[email protected]>

* Clean up code.

Signed-off-by: Jelmer de Wolde <[email protected]>

---------

Signed-off-by: Jelmer de Wolde <[email protected]>
Co-authored-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make a ROS wrapper around Graspnet

3 participants