- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
277 make a ros wrapper #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
      
        
      
      
  
    4 tasks
  
              
                    MaxWaterhout
  
              
              commented
              
                  
                    Oct 3, 2025 
                  
              
              
            
            
| moveit::planning_interface::MoveGroupInterface::ROBOT_DESCRIPTION, | ||
| node->get_namespace())), | ||
| moveit_visual_tools(node, "base", "/rviz_markers") { | ||
| moveit_visual_tools(node, "franka/fr3_link0", "/rviz_markers") { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be namespaced but i dont know how
0cfad2f    to
    1d9f11a      
    Compare
  
    4c10d0c    to
    1d9f11a      
    Compare
  
    1d9f11a    to
    bcc2c3e      
    Compare
  
    Signed-off-by: Jelmer de Wolde <[email protected]>
21de58d    to
    5ccb3a9      
    Compare
  
    Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
    
  Jelmerdw 
      added a commit
      that referenced
      this pull request
    
      Oct 21, 2025 
    
    
      
  
    
      
    
  
* Make a ros wrapper. Signed-off-by: Jelmer de Wolde <[email protected]> * Undo unnecessary changes. Signed-off-by: Jelmer de Wolde <[email protected]> * Introduce gui. Signed-off-by: Jelmer de Wolde <[email protected]> * Visualize gripper pose in Rviz. Signed-off-by: Jelmer de Wolde <[email protected]> * Correct gripper visualization with offset between wrist and tcp. Signed-off-by: Jelmer de Wolde <[email protected]> * Add animated visualization of plan. Signed-off-by: Jelmer de Wolde <[email protected]> * Clean up code. Signed-off-by: Jelmer de Wolde <[email protected]> --------- Signed-off-by: Jelmer de Wolde <[email protected]> Co-authored-by: Jelmer de Wolde <[email protected]> Signed-off-by: Jelmer de Wolde <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Please include a summary of the changes and the related issue.
Mention if this PR is a bug fix, feature addition, or refactor.
Fixes: #277
Testing
Explain how you tested your changes.
Documentation
Additional Notes
Uploading Screencast from 2025-09-26 08-50-38.webm…