287 migrate manipulate pose #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
geurto
force-pushed
the
287-migrate-manipulate_pose
branch
from
8353ac8 to
c24c46e
Compare
Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
Signed-off-by: Peter Geurts <[email protected]>
Jelmerdw
force-pushed
the
287-migrate-manipulate_pose
branch
from
fa9052f to
9eea5cb
Compare
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Signed-off-by: Jelmer de Wolde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request rewrites the
manipulate_pose.pyfile into C++ to increase performance.It also adds unit tests to test basic functionality, such as calling the ExpressPoseInOtherFrame and TransformPose services with a certain transform.
Fixes: #287
Testing
Compiled code locally, developed and ran unit tests to verify functionality.
Documentation
Additional Notes
Any relevant screenshots, logs, or context.