feat: add repair attempt graph #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amishne
force-pushed
the
num-builds
branch
2 times, most recently
from
a28fb5d to
0769518
Compare
amishne
requested review from
AndrewKushnir,
crisbeto and
devversion
as code owners
| return count > 0 ? totalRepairs / count : null; | ||
| }); | ||
|
|
||
| protected repairAttemptsAsGraphData = computed<StackedBarChartData>(() => { |
Collaborator
There was a problem hiding this comment.
I'd propose moving most of the logic from this function (and maybe also the function above) to a new function outside of this class (to keep the class as simple as possible).
Comment on lines
+42
to
+45
| --chart-grade-1: #10b981; /* Emerald 500 (Excellent) */ | ||
| --chart-grade-2: #22c55e; /* Green 500 */ | ||
| --chart-grade-3: #4ade80; /* Green 400 */ | ||
| --chart-grade-4: #84cc16; /* Lime 500 (Great) */ |
Collaborator
There was a problem hiding this comment.
I think we should avoid using green colors for this graph. We can also reduce the number of attempts that we render individually to 5 and collect the remaining ones into a separate bucket (and use the "over 5 attempts" text for it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new graph that appears when running with a repair attempt value greater than 1. It shows the distribution among the applications of how many repairs were needed for them. Screenshot below.