-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add repair attempt graph #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amishne
wants to merge
1
commit into
angular:main
Choose a base branch
from
amishne:num-builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ | |
|
|
||
| &.multiline-tooltip::before { | ||
| white-space: normal; | ||
| width: max-content; | ||
| max-width: 400px; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,17 @@ | |
| --status-text-poor: #eb1515; | ||
| --status-text-neutral: #64748b; | ||
|
|
||
| /* 10-step Green-to-Red Quality Gradient */ | ||
| --chart-grade-1: #10b981; /* Emerald 500 (Excellent) */ | ||
| --chart-grade-2: #22c55e; /* Green 500 */ | ||
| --chart-grade-3: #4ade80; /* Green 400 */ | ||
| --chart-grade-4: #84cc16; /* Lime 500 (Great) */ | ||
|
Comment on lines
+42
to
+45
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should avoid using green colors for this graph. We can also reduce the number of attempts that we render individually to 5 and collect the remaining ones into a separate bucket (and use the "over 5 attempts" text for it). |
||
| --chart-grade-5: #a3e635; /* Lime 400 */ | ||
| --chart-grade-6: #facc15; /* Yellow 400 */ | ||
| --chart-grade-7: #f59e0b; /* Amber 500 (Good) */ | ||
| --chart-grade-8: #f97316; /* Orange 500 */ | ||
| --chart-grade-9: #ef4444; /* Red 500 (Poor) */ | ||
|
|
||
| --tooltip-background-color: light-dark(#111827, #f1f4f9); | ||
| --tooltip-text-color: light-dark(#f9fafb, #1e293b); | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose moving most of the logic from this function (and maybe also the function above) to a new function outside of this class (to keep the class as simple as possible).