Update templateConfig.sh to not break with directorys with space on t… #10898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10898 +/- ##
============================================
- Coverage 15.17% 15.17% -0.01%
- Complexity 11339 11347 +8
============================================
Files 5414 5416 +2
Lines 475185 475621 +436
Branches 57991 58054 +63
============================================
+ Hits 72105 72157 +52
- Misses 395018 395393 +375
- Partials 8062 8071 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13586 |
| "ovm3:https://download.cloudstack.org/systemvm/$CS_VERSION/systemvmtemplate-$VERSION-ovm.raw.bz2" ) | ||
|
|
||
| PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/" | ||
| mkdir -p $PARENTPATH |
There was a problem hiding this comment.
| mkdir -p $PARENTPATH | |
| mkdir -p "$PARENTPATH" |
| echo > $METADATAFILE | ||
| METADATAFILE="${PARENTPATH}metadata.ini" | ||
| echo > "$METADATAFILE" | ||
| SOURCEFILE=${PARENTPATH}'md5sum.txt' |
There was a problem hiding this comment.
| SOURCEFILE=${PARENTPATH}'md5sum.txt' | |
| SOURCEFILE="${PARENTPATH}md5sum.txt" |
| } | ||
|
|
||
| function createMetadataFile() { | ||
| local fileData=$(cat $SOURCEFILE) |
There was a problem hiding this comment.
| local fileData=$(cat $SOURCEFILE) | |
| local fileData=$(cat "$SOURCEFILE") |
|
@vits-hugs |
5 participants
Description
Currently the script of
templateConfig.shdoesn't recognize folders with spaces in their names, which can cause compilation errors, this PR updates the script so that the folders with space in their names are recognized.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
To test this, I renamed my user folder to have a white-space in it, then ran the process of building the project, which runs the
templateConfig.sh, and verified that there wasn't any errors on the building process.