Skip to content

Update templateConfig.sh to not break with directorys with space on t… #10898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from
Open

Update templateConfig.sh to not break with directorys with space on t… #10898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions engine/schema/templateConfig.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function getChecksum() {

function createMetadataFile() {
local fileData=$(cat $SOURCEFILE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local fileData=$(cat $SOURCEFILE)
local fileData=$(cat "$SOURCEFILE")

echo -e "["default"]\nversion = $VERSION.${securityversion}\n" >> $METADATAFILE
echo -e "["default"]\nversion = $VERSION.${securityversion}\n" >> "$METADATAFILE"
for template in "${templates[@]}"
do
section="${template%%:*}"
Expand All @@ -64,7 +64,7 @@ function createMetadataFile() {
checksum=$(getChecksum "$fileData" "$VERSION-$hvName")
downloadurl="${template#*:}"
filename=$(echo ${downloadurl##*'/'})
echo -e "["$section"]\ntemplatename = $templatename\nchecksum = $checksum\ndownloadurl = $downloadurl\nfilename = $filename\n" >> $METADATAFILE
echo -e "["$section"]\ntemplatename = $templatename\nchecksum = $checksum\ndownloadurl = $downloadurl\nfilename = $filename\n" >> "$METADATAFILE"
done
}

Expand All @@ -79,7 +79,7 @@ templates=( "kvm:https://download.cloudstack.org/systemvm/${CS_VERSION}/systemvm

PARENTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/dist/systemvm-templates/"
mkdir -p $PARENTPATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir -p $PARENTPATH
mkdir -p "$PARENTPATH"

METADATAFILE=${PARENTPATH}"metadata.ini"
echo > $METADATAFILE
METADATAFILE="${PARENTPATH}metadata.ini"
echo > "$METADATAFILE"
SOURCEFILE=${PARENTPATH}'md5sum.txt'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SOURCEFILE=${PARENTPATH}'md5sum.txt'
SOURCEFILE="${PARENTPATH}md5sum.txt"

createMetadataFile