java: fix one typo in many files #11284

jbampton · 2025-07-24T10:04:49Z

CheckDataStoreStoragePolicyComplainceCommand -> CheckDataStoreStoragePolicyComplianceCommand

isStoragePoolStoragepolicyComplaince -> isStoragePoolStoragepolicyCompliance

Also renamed the file. So the one typo is:

Complaince is changed to Compliance and also fixed the all lowercase version

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

CheckDataStoreStoragePolicyComplainceCommand -> CheckDataStoreStoragePolicyComplianceCommand Also renamed the file

codecov · 2025-07-24T10:12:48Z

Codecov Report

❌ Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (96ccd7e) to head (f6c4733).
⚠️ Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
...om/cloud/deploy/DeploymentPlanningManagerImpl.java	0.00%	6 Missing ⚠️
...cloud/storage/resource/VmwareStorageProcessor.java	0.00%	3 Missing ⚠️
...e/resource/StorageSubsystemCommandHandlerBase.java	0.00%	1 Missing and 1 partial ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	2 Missing ⚠️
.../xenserver/resource/XenServerStorageProcessor.java	0.00%	2 Missing ⚠️
...nserver/resource/Xenserver625StorageProcessor.java	0.00%	2 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	2 Missing ⚠️
.../CheckDataStoreStoragePolicyComplianceCommand.java	0.00%	1 Missing ⚠️
...torage/allocator/AbstractStoragePoolAllocator.java	0.00%	1 Missing ⚠️
...d/hypervisor/vmware/manager/VmwareManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11284   +/-   ##
=========================================
  Coverage     17.39%   17.39%           
- Complexity    15283    15285    +2     
=========================================
  Files          5889     5889           
  Lines        526141   526141           
  Branches      64234    64234           
=========================================
  Hits          91542    91542           
  Misses       424265   424265           
  Partials      10334    10334

Flag	Coverage Δ
uitests	`3.62% <ø> (ø)`
unittests	`18.44% <4.34%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland · 2025-07-24T10:20:05Z

I think this fix must go in but it is a risky one as a lot of code changes.
@blueorangutan package

blueorangutan · 2025-07-24T10:22:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-24T11:45:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14344

sureshanaparti

clgtm

DaanHoogland · 2025-07-25T07:12:27Z

@blueorangutan test matrix

blueorangutan · 2025-07-25T07:14:03Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-07-26T02:14:00Z

[SF] Trillian test result (tid-13887)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 65039 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13887-kvm-ol8.zip
Smoke tests completed. 141 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_list_zones_metrics	`Error`	0.25	test_metrics_api.py

blueorangutan · 2025-07-26T03:09:57Z

[SF] Trillian test result (tid-13888)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 69056 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13888-kvm-ubuntu22.zip
Smoke tests completed. 140 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_list_zones_metrics	`Error`	0.27	test_metrics_api.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	619.30	test_vpc_vpn.py

blueorangutan · 2025-07-26T07:20:00Z

[SF] Trillian test result (tid-13890)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 84179 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13890-xcpng82.zip
Smoke tests completed. 138 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_arping_in_ssvm	`Failure`	6.27	test_diagnostics.py
test_list_zones_metrics	`Error`	0.22	test_metrics_api.py
test_01_prepare_and_cancel_maintenance	`Error`	0.18	test_ms_maintenance_and_safe_shutdown.py
test_01_deployVMInSharedNetwork	`Failure`	558.32	test_network.py

blueorangutan · 2025-07-27T15:31:28Z

[SF] Trillian test result (tid-13889)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 199827 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t13889-vmware-70u3.zip
Smoke tests completed. 133 look OK, 9 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_3d_gpu_support	`Error`	303.30	test_deploy_vgpu_enabled_vm.py
test_list_zones_metrics	`Error`	0.21	test_metrics_api.py
test_01_prepare_and_cancel_maintenance	`Error`	0.33	test_ms_maintenance_and_safe_shutdown.py
test_01_deploy_vm_on_specific_host	`Error`	12.65	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3602.59	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	2.43	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.39	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	4.40	test_vm_deployment_planner.py
test_01_migrate_vm_strict_tags_success	`Error`	3608.76	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	22.41	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	3608.61	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	6.10	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	24.40	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	3604.61	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	27.40	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	7209.75	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	3609.59	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	9.10	test_vm_strict_host_tags.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	3742.25	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	1952.42	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	3626.01	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	1830.93	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	1826.92	test_vpc_redundant.py
test_02_VPC_default_routes	`Error`	1824.71	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	1814.04	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	`Error`	1814.14	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	3715.74	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	3715.91	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	1814.62	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	3613.99	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	3614.14	test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Error`	1806.97	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	3785.13	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	3785.30	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Error`	1800.96	test_host_maintenance.py

shwstppr

Code LGTM

github-actions · 2025-07-31T11:58:28Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-09-15T07:37:24Z

@blueorangutan package

blueorangutan · 2025-09-15T07:38:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-15T09:06:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15002

DaanHoogland · 2025-09-15T10:48:08Z

@blueorangutan test matrix

blueorangutan · 2025-09-15T10:50:04Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-09-15T11:51:25Z

[SF] Trillian Build Failed (tid-14338)

blueorangutan · 2025-09-16T04:45:48Z

[SF] Trillian test result (tid-14339)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 61368 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t14339-kvm-ubuntu22.zip
Smoke tests completed. 145 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.18	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	31.03	test_kubernetes_clusters.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Failure`	139.31	test_routers_network_ops.py

blueorangutan · 2025-09-16T09:35:52Z

[SF] Trillian test result (tid-14341)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 79131 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t14341-xcpng82.zip
Smoke tests completed. 140 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	211.80	test_events_resource.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.18	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	58.71	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	877.17	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	`Error`	230.32	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	56.58	test_nonstrict_affinity_group.py
test_01_primary_storage_iscsi	`Error`	0.78	test_primary_storage.py
test_01_vpn_usage	`Error`	1.11	test_usage.py
test_11_destroy_vm_and_volumes	`Error`	23.03	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	59.50	test_vm_strict_host_tags.py

jbampton · 2025-09-16T19:06:23Z

@blueorangutan package

blueorangutan · 2025-09-16T19:08:05Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-16T21:02:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15045

blueorangutan · 2025-09-17T04:45:01Z

[SF] Trillian test result (tid-14358)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t14358-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.16	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	27.87	test_kubernetes_clusters.py

blueorangutan · 2025-09-18T08:21:31Z

[SF] Trillian test result (tid-14340)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 246991 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11284-t14340-vmware-70u3.zip
Smoke tests completed. 131 look OK, 10 have errors, 6 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.27	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	41.23	test_kubernetes_clusters.py
test_01_ssl_offloading_isolated_network	`Failure`	767.81	test_ssl_offloading.py
test_02_ssl_offloading_project_vpc	`Failure`	737.22	test_ssl_offloading.py
test_01_vpn_usage	`Error`	1.11	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	15.14	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3606.14	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	4.43	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.44	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.40	test_vm_deployment_planner.py
test_02_offline_migrate_VM_with_two_data_disks	`Error`	3645.74	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	3641.53	test_vm_life_cycle.py
test_04_migrate_detached_volume	`Error`	1836.50	test_vm_life_cycle.py
test_09_expunge_vm	`Failure`	424.53	test_vm_life_cycle.py
test_13_destroy_and_expunge_vm	`Error`	3762.46	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	0.68	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	`Error`	0.66	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	`Error`	0.69	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	`Error`	0.57	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	`Error`	0.58	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Error`	0.90	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	`Error`	0.59	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	`Error`	0.57	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	`Error`	0.62	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	`Error`	0.62	test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure	`Failure`	0.51	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	0.57	test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance	`Error`	1985.71	test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown	`Error`	1812.31	test_vnf_templates.py
ContextSuite context=TestCreateVolume>:teardown	`Error`	2264.72	test_volumes.py
test_06_download_detached_volume	`Failure`	335.74	test_volumes.py
test_01_verify_ipv6_vpc	`Error`	1969.25	test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	3614.55	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	3690.22	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	3689.63	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3690.94	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	3619.24	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_webhook_delivery	`Skipped`	---	test_webhook_delivery.py
all_test_webhook_lifecycle	`Skipped`	---	test_webhook_lifecycle.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

java: fix one typo in many files

d1b6fb9

CheckDataStoreStoragePolicyComplainceCommand -> CheckDataStoreStoragePolicyComplianceCommand Also renamed the file

boring-cyborg bot added component:kvm component:simulator component:storage component:vmware component:XenServer labels Jul 24, 2025

sureshanaparti approved these changes Jul 24, 2025

View reviewed changes

shwstppr approved these changes Jul 28, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Jul 31, 2025

Merge branch 'main' into fix-typo-java

ba9c130

github-actions bot removed the status:has-conflicts label Sep 9, 2025

jbampton and others added 2 commits September 17, 2025 03:24

Merge branch 'main' into fix-typo-java

35e64ec

Fixup typos

f6c4733

vishesh92 merged commit 0108ffd into apache:main Sep 17, 2025
25 of 26 checks passed

vishesh92 mentioned this pull request Sep 17, 2025

pre-commit upgrade codespell; fix spelling; configure gitleaks #10144

Open

14 tasks

jbampton deleted the fix-typo-java branch September 17, 2025 19:47

java: fix one typo in many files #11284

java: fix one typo in many files #11284

Uh oh!

Conversation

jbampton commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 25, 2025

Uh oh!

blueorangutan commented Jul 25, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 26, 2025

Uh oh!

blueorangutan commented Jul 27, 2025

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

DaanHoogland commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 15, 2025

Uh oh!

DaanHoogland commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 15, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

jbampton commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jbampton commented Jul 24, 2025 •

edited

Loading

codecov bot commented Jul 24, 2025 •

edited

Loading