-
Notifications
You must be signed in to change notification settings - Fork 16
NIFI-15155 Add ListenPort API #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-15155 Add ListenPort API #26
Conversation
- Add ListenPortDefinition to PropertyDescriptor that will be serialized as part of flow components - Add ListenComponent interface that components can implement to provide bridge to framework - Update XML Manifest Writer to support PropertyDescriptors with ListenPortDefinitions - Update unit tests
57a2593 to
560f26e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @kevdoran. The new interfaces and corresponding implementations look clear and straightforward. I noted a few very minor recommendations, but otherwise this should be ready to go forward.
src/main/java/org/apache/nifi/components/listen/ListenComponent.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/listen/ListenPort.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/listen/ListenPort.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/listen/StandardListenPort.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/components/listen/StandardListenPortDefinition.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @exceptionfactory. I think I've addressed all your comments, but let me know if you spot anything else you'd like me to change. |
|
@exceptionfactory I added one more commit based on testing in apache/nifi#10476. For a processor such as ListenHTTP that can define multiple ports, it will be helpful to provide the property name as contextual information for ports discovered by the framework. |
Thanks for the updates @kevdoran. I agree having a distinguishing name is helpful. Rather than linking directly to the property name, calling the method |
0d97a60 to
dd1dca0
Compare
Thanks for the feedback @exceptionfactory. I really like this suggestion, and I've pushed an update to rename that field to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the adjustments and keeping things moving with the implementation draft pull request @kevdoran. The latest version looks good! +1 merging
Summary
NIFI-15155
I had two goals in mind:
Keeping this in draft status until downstream changes for NIFI-15156 are farther along. See apache/nifi#10476 for draft changes for NIFI-15156.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch