Skip to content

Conversation

@kevdoran
Copy link
Contributor

@kevdoran kevdoran commented Oct 29, 2025

Summary

NIFI-15156

Depends on apache/nifi-api#26 (NIFI-15155)

  • Update Listen Processors and Controller Services to implement ListenComponent interface
  • Update Listen Processors and Controller Services to identify ListenPortDefinition properties
  • Add draft REST API Controller, Entity, and DTO for listing Listen Ports
  • Refactor ListenSyslog so that the transport protocol for a given port property is static and no longer configurable at runtime while still allowing users to choose between UDP and TCP for the processor.
  • Update Manifest serializers and deserializers to include ListenPortDefinition for PropertyDescriptors

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Update Listen Processors and Controller Services to implement ListenComponent interface
- Update Listen Processors and Controller Services to identify ListenPortDefinition properties
- Add draft REST API Controller, Entity, and DTO for listing Listen Ports
- Refactor ListenSyslog so that the transport protocol for a given port property is static and no longer configurable at runtime
  while still allowing users to choose between UDP and TCP for the processor.
- Update Manifest serializers and deserializers to include ListenPortDefinition for PropertyDescriptors
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting these changes @kevdoran.

It looks like there are a number of dependency version regressions in the parent pom.xml that need to be reverted.

To keep of the scope of changes more manageable, it might be helpful to decouple the ListenSyslog property changes into a separate pull request. That would also serve to highlight those changes as different than just adding the new mapping.

I plan to review more closely after reviewing the API changes, but thought it would be helpful to note these items for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants