fix(imgix): types for combined 'auto' operations

[GeKorm]

In Imgix, the type for auto is incorrect. As the doc comment says, it can be a combination of values

unpic/src/providers/imgix.ts

Line 80 in 482ca8f

* @example "format,compress"

All combinations are permitted in this PR, including some which are nonsensical but still valid format,format,format,format. However, these are still valid imgix URLs.

One complication might be this line:

unpic/src/providers/imgix.ts

Line 238 in 482ca8f

url.searchParams.has("fm") && url.searchParams.get("auto") === "format"

Imgix has its own logic to handle auto=format and fm=, which unpic overrides above. Should I update this to handle cases like auto=compress,format as well, or is it OK to fall back to Imgix's handling?

[ascorbic]

Thanks. I reckon it's best we let imgix handle its own logic there, and we should just pass through the options unchanged.

[ascorbic]

I think we should allow boolean true here too. I won't block on that, because it should also have runtime handling, but it would be a good thing to have as a follow-up.

[GeKorm]

That's how I did it initially, but in the end I felt it could be confusing.

0 <Image />
1 <Image auto />
2 <Image auto="compress" />
3 <Image auto="true,compress" />
4 <Image auto="format" />

Without digging into how it works I expected that (1) would be implied in (2) as a truthy value, but it needs to be explicit like in (3). What's more, if omitted (0) it kinda breaks the convention with booleans being falsy by default, when in reality the default is (4) auto="format".

Despite all this, I don't have a particularly strong opinion about it. It should be fine, as long as it's documented with @default and a short explanation. I'd like to open a follow-up Imgix PR with some improvements and more operations, so I'll include it there.

Edit: Thanks for responding so quickly by the way!

[ascorbic]

Thanks!