Skip to content

Trim imports atmosphere shaders #21829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Trim imports atmosphere shaders #21829

wants to merge 6 commits into from
+18 −32

Conversation

@hukasu
Copy link
Contributor

@hukasu hukasu commented Nov 14, 2025

Objective

Some shaders on the atmosphere module of bevy_pbr have many unused imports

Solution

Trim imports of the offending shaders.

Testing

atmosphere example

@hukasu hukasu added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Shaders This code uses GPU shader languages labels Nov 14, 2025
@hukasu hukasu added the C-Code-Quality A section of code that is hard to understand or change label Nov 14, 2025
mate-h
mate-h approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@mate-h mate-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and thanks for the improvement.

@ecoskey ecoskey added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mate-h mate-h mate-h approved these changes

@ecoskey ecoskey ecoskey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Shaders This code uses GPU shader languages S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hukasu @mate-h @ecoskey